Rollback PR is not created for yanked Crate versions #33837
Unanswered
pyrrho
asked this question in
Request Help
Replies: 1 comment 2 replies
-
I suspect that renovate is treating yanked versions as deprecated, and not removed. Are they actually removed, e.g. if you have it in a lock file from earlier when it was successfully installed, and run "cargo install" then it will fail? |
Beta Was this translation helpful? Give feedback.
2 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
How are you running Renovate?
Self-hosted Renovate
If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.
targeting GitHub with renovate v39.133.2
Please tell us more about your question or problem
I have a repository that is currently importing axum v0.8.2 and axum-extra 0.11.0. Both of these crate versions were yanked on 2025/01/21. My self-hosted renovate config has
"rollbackPrs": true
set, but renovate has not opened rollback PRs for either version.I put together a minimal repro that only imports those two axum crates at the yanked version, in part to narrow renovate's debug log. It didn't help much, but a minimal repro is a minimal repro. I'm sorry to say that I've copied the entire renovate debug log into the detail fold below because I don't see anything interesting in there. You millage may vary, of course, but I'm sorry for not being able to narrow that down.
Some notes about the repro repository,
I had to manually modify the Cargo.lock to set the yanked versions, and you can see exactly how I did that in the git log.
cargo
refuses to generate a Cargo.lock file if the Cargo.toml is targeting yanked crates, so I first generated the .lock with axum-extras 0.10.0 and then edited the .lock to trickcargo
into pulling and building with the yanked versions.The Cargo.toml is targeting a version range for axum (
0.8.0
) that includes not-yanked versions, rather than the specific yanked version (=0.8.2
). I wouldn't be surprised for a correct rollback to occur as part of a lockfile maintenance operation in this case, rather than as a per-crate upgrade (or... downgrade, I guess). The Cargo.toml is targeting a yanked version range for auxm-extra, though (0.11.0
) so I'd definitely expect to see a rollback PR for that.cargo update
errors out in this state;As far as I'm aware, there isn't a way to have
cargo update
perform a downgrade off of a yanked version, which is... honestly, probably for the best?Logs (if relevant)
Logs
Beta Was this translation helpful? Give feedback.
All reactions