Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate Visual Diff URL history #506

Closed
ericholscher opened this issue Jan 23, 2025 · 1 comment
Closed

Integrate Visual Diff URL history #506

ericholscher opened this issue Jan 23, 2025 · 1 comment
Assignees
@humitos

Comments

@ericholscher
Copy link
Member

We want to make sure the URL history change works with single page apps.

Originally posted by @humitos in #494 (comment)
@ericholscher ericholscher mentioned this issue Jan 23, 2025
Merged
@humitos humitos self-assigned this Jan 27, 2025
@github-project-automation github-project-automation bot moved this to Planned in 📍Roadmap Jan 27, 2025
humitos added a commit that referenced this issue Jan 30, 2025
@humitos
Trigger the URL_CHANGED event only if from/to URL are different
0a685ed 
Check if from/to URL are different after removing `?readthedocs-diff=`
attribute because we don't want to trigger the even when the user enabled
docdiff in the current page.

Closes #506
@humitos humitos mentioned this issue Jan 30, 2025
Merged
@humitos humitos moved this from Planned to Needs review in 📍Roadmap Jan 30, 2025
humitos added a commit that referenced this issue Feb 4, 2025
@humitos
Trigger the URL_CHANGED event only if from/to URL are different (#516)
d1c96fe 
Check if from/to URL are different after removing `?readthedocs-diff=`
attribute because we don't want to trigger the even when the user
enabled
docdiff in the current page.

Closes #506
@humitos
Copy link
Member

humitos commented Feb 4, 2025

Done in #516, not sure why it didn't close it automatically.

@humitos humitos closed this as completed Feb 4, 2025
@github-project-automation github-project-automation bot moved this from Needs review to Done in 📍Roadmap Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@humitos humitos

Labels
None yet
Projects
📍Roadmap
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ericholscher @humitos