Skip to content

Visual diff and link previews conflict #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
humitos opened this issue Dec 10, 2024 · 1 comment
Open

Visual diff and link previews conflict #469

humitos opened this issue Dec 10, 2024 · 1 comment
Labels
Bug A bug

Comments

@humitos
Copy link
Member

humitos commented Dec 10, 2024

With #465 we deployed a way to re-trigger the setup for the link previews when visual diff is enabled/disabled. It works well, but it seems that the events attached to the elements like mouseover is not listened anymore and the tooltip disappears when you hover it.

Peek 2024-12-10 18-12

@humitos humitos added the Bug A bug label Dec 10, 2024
@ericholscher
Copy link
Member

I looked into this a bit and it seems we're creating multiple events on the node, which I think is causing weird issues. I have a partial fix which I just pushed up, but it still has issues with the previews in the diff'd content.

ericholscher added a commit that referenced this issue Jan 8, 2025
@humitos humitos changed the title Visual diff and link previews Visual diff and link previews conflict Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug
Projects
None yet
Development

No branches or pull requests

2 participants