-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notification: "default version" shouldn't show "This may be an outdated version" #406
Comments
Sure. The example is the PROJ project mentioned in #402. We've turn of the warning as recommended so at the moment it doesn't show. But from the settings panel you can see that we've got the 9.5 branch as the default version: I basically just found it odd that the default version would result in a warning. |
Don't show the notification "This may be an old version of this documentation" if the reader is currently reading the `Project.default_version`. I'm on the fence about doing this part of the default logic or a config on its own. I'll probably change it to a config after thinking a little more, but pushing these changes for now. Closes #406
I opened a POC in #407. I'm still on the fence about adding this logic to the default algorithm or making it an config in the Addons tab. Would it be better for you to have an explicit checkbox in the Addons -> Notification tab saying "[ ] Skip showing a notification on project's default version"? |
That would work just as well |
I'm unsure how our docs are configured, but we also see a spurious "This is the latest development version" notification on our docs at https://cellgeni.readthedocs.io/en/latest/index.html, despite there being no stable version (the link 404s). |
The link works for me and goes to https://cellgeni.readthedocs.io/en/stable/
You can disable this notification from the dashboard. Check our docs at https://docs.readthedocs.io/en/stable/versions.html#version-warning-notifications |
🤦♀️ I tried at https://cellgeni.readthedocs.io/en/latest/farmer.html which is brand new and therefore has no stable page, apologies... Thanks, I clearly need to investigate how we've set this up. |
We just deployed this. You should not see a notification on the default version now. |
(posted by @ kbevers in #402 (comment))
I'm opening this issue to research about this a little more.
@kbevers do you have an example where you getting the unexpected behavior? That would be pretty useful to me to understand what's going on here.
The text was updated successfully, but these errors were encountered: