Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flyout is giving me app.app URLS #380

Closed
ericholscher opened this issue Sep 19, 2024 · 0 comments · Fixed by #382
Closed

Flyout is giving me app.app URLS #380

ericholscher opened this issue Sep 19, 2024 · 0 comments · Fixed by #382
Assignees
@humitos

Comments

@ericholscher
Copy link
Member

ericholscher commented Sep 19, 2024 •
edited
Loading

On the new ext-theme proxito instances, the Addons Flyout is showing invalid URLs:

<a href="https://app.app.readthedocs.com/projects/readthedocs-ops/?utm_source=readthedocs-ops&utm_content=flyout">Project Home</a>
@github-project-automation github-project-automation bot moved this to Planned in 📍Roadmap Sep 19, 2024
@humitos humitos self-assigned this Sep 19, 2024
humitos added a commit that referenced this issue Sep 20, 2024
@humitos
Links to new dashboard
a19e739 
Now that we are using El Proxito with the new templates, we end up with
`app.app.readthedocs.org` links.

This is an improvement of that simple replacement to remove the duplicated
`app.` from the resulting link.

I want to keep this code around as a way to keep promoting the new dashboard.
Once we are fully on the new templates, we can remove this code.

Closes #380
@humitos humitos moved this from Planned to Needs review in 📍Roadmap Sep 20, 2024
@humitos humitos mentioned this issue Sep 20, 2024
Merged
@github-project-automation github-project-automation bot moved this from Needs review to Done in 📍Roadmap Sep 23, 2024
@github-project-automation github-project-automation bot moved this from Needs review to Done in 📍Roadmap Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@humitos humitos

Labels
None yet
Projects
📍Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Links to new dashboard readthedocs/addons
2 participants
@ericholscher @humitos