-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate with error pages #371
Comments
👍🏼
URL where you can notice this behavior: https://dev.readthedocs.io/en/latest/notfound.html I've tried this some time ago and I found that's not possible to know what's the status code for the original documentation URL from JavaScript. I will add the status code using CF Worker and reading it from JavaScript following the pattern we are using to read other similar data we don't have access from JavaScript. |
We need to know what's the HTTP status for the original request to be able to decide what addons will be enabled. There are some addons we want to disable on 404s for example. Related: readthedocs/addons#371
It reads a META tag `readthedocs-http-status` to get the HTTP status code for the original request to the documentation URL. It uses this HTTP status code to decide if each of the addons should be enabled or not. Closes #371 Requires readthedocs/common#222
I opened these PRs to solve this issue: |
We need to know what's the HTTP status for the original request to be able to decide what addons will be enabled. There are some addons we want to disable on 404s for example. Related: readthedocs/addons#371
The documentation error pages used to direct users to search in our dashboard with an input. I noted here that we should probably rework the search feature to instead use the in-doc search instead:
One other point to integrating with the error pages is that Addons are active on error pages currently -- flyout, version warnings, etc. These feel a little out of place on error pages, and might be conflicting warnings to readers.
The text was updated successfully, but these errors were encountered: