Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add Validate RayCluster spec in webhook #2737

Closed
2 tasks done
CheyuWu opened this issue Jan 13, 2025 · 0 comments
Closed
2 tasks done

[Feature] Add Validate RayCluster spec in webhook #2737

CheyuWu opened this issue Jan 13, 2025 · 0 comments
Labels
enhancement New feature or request triage

Comments

@CheyuWu
Copy link
Contributor

CheyuWu commented Jan 13, 2025

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

Relative to #2726 (comment)
We validated the RayCluster spec in RayClusterReconciler

The validation webhook is usually the recommended way to validate a k8s CR, but users can choose not to enable it. That is the reason we need to do validation in both reconciliation and the webhook.

Use case

No response

Related issues

Pull Request #2726
Issue #2694

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@CheyuWu CheyuWu added enhancement New feature or request triage labels Jan 13, 2025
@CheyuWu CheyuWu closed this as completed Jan 13, 2025
@CheyuWu CheyuWu closed this as not planned Won't fix, can't repro, duplicate, stale Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@CheyuWu