Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm chart supports using namespaceOverride. #473

Open
ace0527 opened this issue Jan 10, 2025 · 2 comments
Open

Helm chart supports using namespaceOverride. #473

ace0527 opened this issue Jan 10, 2025 · 2 comments

Comments

@ace0527
Copy link

ace0527 commented Jan 10, 2025

Currently, the namespace attribute value of all namespace-related components in the templates is namespace: {{ .Release.Namespace }}, making it impossible to use namespaceOverride in dependencies to define the namespace.
A more flexible and compatible implementation should be as follows:
Add a template:

{{- define "local-path-provider.namespace" -}}
{{- if .Values.namespaceOverride }}
{{- .Values.namespaceOverride }}
{{- else }}
{{- .Release.Namespace }}
{{- end }}
{{- end -}}

Assign the namespace to the component:

namespace: {{ include "phpmyadmin.namespace" . }}

Currently, to modify the namespace, you can only pull the dependency locally and modify the code.
I hope future versions can be compatible with namespaceOverride.

@tzabbi
Copy link
Contributor

tzabbi commented Feb 12, 2025

Hey there,
can someone review my PR please? :)

@derekbit
Copy link
Member

@tzabbi I will review it. Thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants