You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fix race condition when terminating supervisor after restoring default signals
We'd terminate the supervisor and let it consume the shutdown timeout, so it'd start
the immediate shutdown, then do some assertions and terminate the supervisor again
before it had the chance to finish, and as such, the TERM signal would arrive sometimes
before and sometimes after default signal handlers would have been restored, resulting in
an error (harmless, but annoying) as:
```
..solid_queue/test/test_helper.rb:51: warning: Exception in finalizer #<Proc:0x00000001083ee550 (lambda)>
..solid_queue/test/test_helper.rb:51:in `fork': SIGTERM (SignalException)
from ..solid_queue/test/test_helper.rb:51:in `run_supervisor_as_fork'
from ..solid_queue/test/integration/processes_lifecycle_test.rb:9:in `block in <class:ProcessLifecycleTest>'
```
0 commit comments