Skip to content
This repository was archived by the owner on May 2, 2021. It is now read-only.

Commit 8e8c78b

Browse files
author
Tae Won Ha
committedMay 24, 2013
#10 renamed font converter to font manager and using TBBean protocol in font manager and id generator
1 parent 78bb559 commit 8e8c78b

10 files changed

+35
-33
lines changed
 

‎Qmind.xcodeproj/project.pbxproj

Lines changed: 16 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@
3838
4B03B2511628726500E5ECA2 /* TBCacao.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 4B03B2481628724000E5ECA2 /* TBCacao.framework */; };
3939
4B03B2521628726E00E5ECA2 /* TBCacao.framework in CopyFiles */ = {isa = PBXBuildFile; fileRef = 4B03B2481628724000E5ECA2 /* TBCacao.framework */; };
4040
4B10DDA2174F96E000B58F6E /* mindmap-reader-no-id-test.mm in CopyFiles */ = {isa = PBXBuildFile; fileRef = 1929B0345B0EF35021CB20DF /* mindmap-reader-no-id-test.mm */; };
41+
4B10DDAA174FA0DB00B58F6E /* QMIdGenerator.m in Sources */ = {isa = PBXBuildFile; fileRef = 1929BB6573724B1C6F3E369C /* QMIdGenerator.m */; };
4142
4B12E236168CC34900D972BE /* IconTest.m in Sources */ = {isa = PBXBuildFile; fileRef = 1929BC2901D96DABE95AE4BB /* IconTest.m */; };
4243
4B15777416A2EFFE0048480E /* QTestKit.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 4B15777116A2EFEF0048480E /* QTestKit.framework */; };
4344
4B15777516A2F0000048480E /* Qkit.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 4B15776F16A2EFEF0048480E /* Qkit.framework */; };
@@ -65,7 +66,7 @@
6566
4B5CB61715E1187500E05BD7 /* QMRootNode.m in Sources */ = {isa = PBXBuildFile; fileRef = 4BFCD7AC14F3E32A00850953 /* QMRootNode.m */; };
6667
4B5CB61815E1187500E05BD7 /* QMNode.m in Sources */ = {isa = PBXBuildFile; fileRef = 4B8564F414E4643A00C6FF0A /* QMNode.m */; };
6768
4B5CB61A15E1187500E05BD7 /* QMDocument.m in Sources */ = {isa = PBXBuildFile; fileRef = 4B8564D814E461DC00C6FF0A /* QMDocument.m */; };
68-
4B5CB61B15E1187500E05BD7 /* QMFontConverter.m in Sources */ = {isa = PBXBuildFile; fileRef = 4BFCD7AC14F3E32A00850944 /* QMFontConverter.m */; };
69+
4B5CB61B15E1187500E05BD7 /* QMFontManager.m in Sources */ = {isa = PBXBuildFile; fileRef = 4BFCD7AC14F3E32A00850944 /* QMFontManager.m */; };
6970
4B5CB61C15E1187500E05BD7 /* QMProxyNode.m in Sources */ = {isa = PBXBuildFile; fileRef = 4B85653514E46D6800C6FF15 /* QMProxyNode.m */; };
7071
4B5CB61D15E1187500E05BD7 /* QMMindmapWriter.m in Sources */ = {isa = PBXBuildFile; fileRef = 4B85653514E46D6800C6FF11 /* QMMindmapWriter.m */; };
7172
4B5CB61E15E1187500E05BD7 /* QMMindmapReader.m in Sources */ = {isa = PBXBuildFile; fileRef = 4B85653514E46D6800C6FF0D /* QMMindmapReader.m */; };
@@ -77,7 +78,7 @@
7778
4B5CB64F15E11AA500E05BD7 /* IconManagerTest.m in Sources */ = {isa = PBXBuildFile; fileRef = 4BFCD7AC14F3E32A00850941 /* IconManagerTest.m */; };
7879
4B5CB65015E11B2200E05BD7 /* QMMindmapViewDataSourceImplTest.m in Sources */ = {isa = PBXBuildFile; fileRef = 4BFCD7AC14F3E32A008509AB /* QMMindmapViewDataSourceImplTest.m */; };
7980
4B5CB65115E11B2E00E05BD7 /* DocumentWindowControllerTest.m in Sources */ = {isa = PBXBuildFile; fileRef = 4B85653514E46D6800C6FF5B /* DocumentWindowControllerTest.m */; };
80-
4B5CB65215E11B3D00E05BD7 /* FontConverterTest.m in Sources */ = {isa = PBXBuildFile; fileRef = 4BFCD7AC14F3E32A00850949 /* FontConverterTest.m */; };
81+
4B5CB65215E11B3D00E05BD7 /* QMFontManagerTest.m in Sources */ = {isa = PBXBuildFile; fileRef = 4BFCD7AC14F3E32A00850949 /* QMFontManagerTest.m */; };
8182
4B5CB65615E11B6200E05BD7 /* DocumentTest.m in Sources */ = {isa = PBXBuildFile; fileRef = 4B85653514E46D6800C6FF34 /* DocumentTest.m */; };
8283
4B5CB65715E11B6B00E05BD7 /* MindmapWriterTest.m in Sources */ = {isa = PBXBuildFile; fileRef = 4B85653514E46D6800C6FF1F /* MindmapWriterTest.m */; };
8384
4B5CB65815E11C1000E05BD7 /* RootNodeTest.m in Sources */ = {isa = PBXBuildFile; fileRef = 4BFCD7AC14F3E32A00850958 /* RootNodeTest.m */; };
@@ -148,7 +149,7 @@
148149
4BB45FEF1736976F00B2B15D /* Cocoa.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 4B8564C514E461DC00C6FF0A /* Cocoa.framework */; };
149150
4BB45FF21736978D00B2B15D /* Qkit.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 4B15776F16A2EFEF0048480E /* Qkit.framework */; };
150151
4BB45FF31736979900B2B15D /* Qkit.framework in CopyFiles */ = {isa = PBXBuildFile; fileRef = 4B15776F16A2EFEF0048480E /* Qkit.framework */; };
151-
4BB45FF4173697B500B2B15D /* QMFontConverter.m in Sources */ = {isa = PBXBuildFile; fileRef = 4BFCD7AC14F3E32A00850944 /* QMFontConverter.m */; };
152+
4BB45FF4173697B500B2B15D /* QMFontManager.m in Sources */ = {isa = PBXBuildFile; fileRef = 4BFCD7AC14F3E32A00850944 /* QMFontManager.m */; };
152153
4BB45FF5173697B500B2B15D /* QMIconManager.m in Sources */ = {isa = PBXBuildFile; fileRef = 4BFCD7AC14F3E32A0085093C /* QMIconManager.m */; };
153154
4BB45FF81736989100B2B15D /* QMManualBeanProvider.m in Sources */ = {isa = PBXBuildFile; fileRef = 1929B43F698543362E51BAB9 /* QMManualBeanProvider.m */; };
154155
4BB460031736A01100B2B15D /* QMDocument.m in Sources */ = {isa = PBXBuildFile; fileRef = 4B8564D814E461DC00C6FF0A /* QMDocument.m */; };
@@ -180,7 +181,7 @@
180181
4BFCD7AC14F3E32A00850939 /* IconsFreeMindToQmind.plist in Resources */ = {isa = PBXBuildFile; fileRef = 4BFCD7AC14F3E32A00850938 /* IconsFreeMindToQmind.plist */; };
181182
4BFCD7AC14F3E32A0085093B /* IconsFreeMindToQmind.plist in Resources */ = {isa = PBXBuildFile; fileRef = 4BFCD7AC14F3E32A00850938 /* IconsFreeMindToQmind.plist */; };
182183
4BFCD7AC14F3E32A0085093D /* QMIconManager.m in Sources */ = {isa = PBXBuildFile; fileRef = 4BFCD7AC14F3E32A0085093C /* QMIconManager.m */; };
183-
4BFCD7AC14F3E32A00850945 /* QMFontConverter.m in Sources */ = {isa = PBXBuildFile; fileRef = 4BFCD7AC14F3E32A00850944 /* QMFontConverter.m */; };
184+
4BFCD7AC14F3E32A00850945 /* QMFontManager.m in Sources */ = {isa = PBXBuildFile; fileRef = 4BFCD7AC14F3E32A00850944 /* QMFontManager.m */; };
184185
4BFCD7AC14F3E32A00850954 /* QMRootNode.m in Sources */ = {isa = PBXBuildFile; fileRef = 4BFCD7AC14F3E32A00850953 /* QMRootNode.m */; };
185186
4BFCD7AC14F3E32A0085095C /* QMRootCell.m in Sources */ = {isa = PBXBuildFile; fileRef = 4BFCD7AC14F3E32A0085095B /* QMRootCell.m */; };
186187
4BFCD7AC14F3E32A00850969 /* QMCellStateManager.m in Sources */ = {isa = PBXBuildFile; fileRef = 4BFCD7AC14F3E32A00850968 /* QMCellStateManager.m */; };
@@ -475,9 +476,9 @@
475476
4BFCD7AC14F3E32A0085093C /* QMIconManager.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = QMIconManager.m; sourceTree = "<group>"; };
476477
4BFCD7AC14F3E32A00850940 /* QMIconManager.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = QMIconManager.h; sourceTree = "<group>"; };
477478
4BFCD7AC14F3E32A00850941 /* IconManagerTest.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IconManagerTest.m; sourceTree = "<group>"; };
478-
4BFCD7AC14F3E32A00850944 /* QMFontConverter.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = QMFontConverter.m; sourceTree = "<group>"; };
479-
4BFCD7AC14F3E32A00850948 /* QMFontConverter.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = QMFontConverter.h; sourceTree = "<group>"; };
480-
4BFCD7AC14F3E32A00850949 /* FontConverterTest.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = FontConverterTest.m; sourceTree = "<group>"; };
479+
4BFCD7AC14F3E32A00850944 /* QMFontManager.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = QMFontManager.m; sourceTree = "<group>"; };
480+
4BFCD7AC14F3E32A00850948 /* QMFontManager.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = QMFontManager.h; sourceTree = "<group>"; };
481+
4BFCD7AC14F3E32A00850949 /* QMFontManagerTest.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = QMFontManagerTest.m; sourceTree = "<group>"; };
481482
4BFCD7AC14F3E32A0085094F /* QMMindmapViewComponentTest.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = QMMindmapViewComponentTest.m; sourceTree = "<group>"; };
482483
4BFCD7AC14F3E32A00850952 /* cell-population-test.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = "cell-population-test.mm"; sourceTree = "<group>"; };
483484
4BFCD7AC14F3E32A00850953 /* QMRootNode.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = QMRootNode.m; sourceTree = "<group>"; };
@@ -767,7 +768,7 @@
767768
4B85653514E46D6800C6FF18 /* Document */ = {
768769
isa = PBXGroup;
769770
children = (
770-
4BFCD7AC14F3E32A00850949 /* FontConverterTest.m */,
771+
4BFCD7AC14F3E32A00850949 /* QMFontManagerTest.m */,
771772
4B85653514E46D6800C6FF34 /* DocumentTest.m */,
772773
4B85653514E46D6800C6FF1F /* MindmapWriterTest.m */,
773774
4B85653514E46D6800C6FF19 /* MindmapReaderTest.m */,
@@ -816,8 +817,8 @@
816817
4B85653514E46D6800C6FF2F /* Internal */ = {
817818
isa = PBXGroup;
818819
children = (
819-
4BFCD7AC14F3E32A00850948 /* QMFontConverter.h */,
820-
4BFCD7AC14F3E32A00850944 /* QMFontConverter.m */,
820+
4BFCD7AC14F3E32A00850948 /* QMFontManager.h */,
821+
4BFCD7AC14F3E32A00850944 /* QMFontManager.m */,
821822
4B85653514E46D6800C6FF15 /* QMProxyNode.m */,
822823
4B85653514E46D6800C6FF14 /* QMProxyNode.h */,
823824
4B85653514E46D6800C6FF11 /* QMMindmapWriter.m */,
@@ -1203,7 +1204,7 @@
12031204
4BFCD74F14F3D33600850924 /* QMAppDelegate.m in Sources */,
12041205
4BFCD7AC14F3E32A00850926 /* QMCellDrawer.m in Sources */,
12051206
4BFCD7AC14F3E32A0085093D /* QMIconManager.m in Sources */,
1206-
4BFCD7AC14F3E32A00850945 /* QMFontConverter.m in Sources */,
1207+
4BFCD7AC14F3E32A00850945 /* QMFontManager.m in Sources */,
12071208
4BFCD7AC14F3E32A00850954 /* QMRootNode.m in Sources */,
12081209
4BFCD7AC14F3E32A0085095C /* QMRootCell.m in Sources */,
12091210
4BFCD7AC14F3E32A00850969 /* QMCellStateManager.m in Sources */,
@@ -1226,13 +1227,14 @@
12261227
isa = PBXSourcesBuildPhase;
12271228
buildActionMask = 2147483647;
12281229
files = (
1230+
4B10DDAA174FA0DB00B58F6E /* QMIdGenerator.m in Sources */,
12291231
4BB460061736A03F00B2B15D /* QMProxyNode.m in Sources */,
12301232
4BB460071736A03F00B2B15D /* QMMindmapReader.m in Sources */,
12311233
4BB460081736A03F00B2B15D /* QMMindmapViewDataSourceImpl.m in Sources */,
12321234
4BB460091736A03F00B2B15D /* QMDocumentWindowController.m in Sources */,
12331235
4BB460031736A01100B2B15D /* QMDocument.m in Sources */,
12341236
4BB45FF81736989100B2B15D /* QMManualBeanProvider.m in Sources */,
1235-
4BB45FF4173697B500B2B15D /* QMFontConverter.m in Sources */,
1237+
4BB45FF4173697B500B2B15D /* QMFontManager.m in Sources */,
12361238
4BB45FF5173697B500B2B15D /* QMIconManager.m in Sources */,
12371239
4BB45FDF173647C400B2B15D /* QMAppSettings.m in Sources */,
12381240
4BB45FE0173647C400B2B15D /* QMTextLayoutManager.m in Sources */,
@@ -1277,7 +1279,7 @@
12771279
4B5CB65915E11C1000E05BD7 /* NodeTest.m in Sources */,
12781280
4B5CB65715E11B6B00E05BD7 /* MindmapWriterTest.m in Sources */,
12791281
4B5CB65615E11B6200E05BD7 /* DocumentTest.m in Sources */,
1280-
4B5CB65215E11B3D00E05BD7 /* FontConverterTest.m in Sources */,
1282+
4B5CB65215E11B3D00E05BD7 /* QMFontManagerTest.m in Sources */,
12811283
4B5CB65115E11B2E00E05BD7 /* DocumentWindowControllerTest.m in Sources */,
12821284
4B5CB65015E11B2200E05BD7 /* QMMindmapViewDataSourceImplTest.m in Sources */,
12831285
4B5CB64D15E11AA500E05BD7 /* QMBaseTestCase.m in Sources */,
@@ -1299,7 +1301,7 @@
12991301
4B5CB61715E1187500E05BD7 /* QMRootNode.m in Sources */,
13001302
4B5CB61815E1187500E05BD7 /* QMNode.m in Sources */,
13011303
4B5CB61A15E1187500E05BD7 /* QMDocument.m in Sources */,
1302-
4B5CB61B15E1187500E05BD7 /* QMFontConverter.m in Sources */,
1304+
4B5CB61B15E1187500E05BD7 /* QMFontManager.m in Sources */,
13031305
4B5CB61C15E1187500E05BD7 /* QMProxyNode.m in Sources */,
13041306
4B5CB61D15E1187500E05BD7 /* QMMindmapWriter.m in Sources */,
13051307
4B5CB61E15E1187500E05BD7 /* QMMindmapReader.m in Sources */,

‎Qmind/QMFontConverter.h renamed to ‎Qmind/QMFontManager.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,14 @@
99
#import <Cocoa/Cocoa.h>
1010

1111
@class QMAppSettings;
12+
@protocol TBBean;
1213
@protocol TBInitializingBean;
1314

1415
/**
1516
* Converts the attributes of <font> element to NSFont and vice versa. If we have the default font at hand,
1617
* we do nothing.
1718
*/
18-
@interface QMFontConverter : NSObject <TBInitializingBean>
19+
@interface QMFontManager : NSObject <TBBean, TBInitializingBean>
1920

2021
@property (weak) QMAppSettings *settings;
2122
@property (unsafe_unretained) NSFontManager *fontManager;

‎Qmind/QMFontConverter.m renamed to ‎Qmind/QMFontManager.m

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
*/
88

99
#import <TBCacao/TBCacao.h>
10-
#import "QMFontConverter.h"
10+
#import "QMFontManager.h"
1111
#import <Qkit/Qkit.h>
1212
#import "QMAppSettings.h"
1313

@@ -20,11 +20,10 @@
2020
static NSString * const qDefaultSerifFondName = @"Serif";
2121
static NSString * const qTimesFontName = @"Times";
2222

23-
@implementation QMFontConverter {
23+
@implementation QMFontManager {
2424
NSFont *_defaultFont;
2525
}
2626

27-
TB_BEAN
2827
TB_AUTOWIRE(settings)
2928
TB_AUTOWIRE(fontManager)
3029

‎Qmind/QMIdGenerator.h

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,9 @@
88

99
#import <Foundation/Foundation.h>
1010

11-
@interface QMIdGenerator : NSObject
11+
@protocol TBBean;
12+
13+
@interface QMIdGenerator : NSObject <TBBean>
1214

1315
- (NSString *)nodeId;
1416

‎Qmind/QMIdGenerator.m

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,6 @@
1111

1212
@implementation QMIdGenerator
1313

14-
TB_BEAN
15-
1614
#pragma mark Public
1715
- (NSString *)nodeId {
1816
return [NSString stringWithFormat:@"ID_%@", [self uuid]];

‎Qmind/QMMindmapWriter.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,14 +9,14 @@
99
#import <Foundation/Foundation.h>
1010

1111
@class QMRootNode;
12-
@class QMFontConverter;
12+
@class QMFontManager;
1313

1414
/**
1515
* Converts the internal node structure to NSData such that you can write it down. The result will be a mm file.
1616
*/
1717
@interface QMMindmapWriter : NSObject
1818

19-
@property (weak) QMFontConverter *fontConverter;
19+
@property (weak) QMFontManager *fontConverter;
2020

2121
/**
2222
* Returns the whole mindmap as NSData such that we can save it to the disk.

‎Qmind/QMMindmapWriter.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
#import "QMMindmapWriter.h"
1111
#import "QMNode.h"
1212
#import "QMDocument.h"
13-
#import "QMFontConverter.h"
13+
#import "QMFontManager.h"
1414
#import "QMRootNode.h"
1515

1616
@implementation QMMindmapWriter

‎Qmind/QMProxyNode.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
@class QMNode;
1212
@class QMMindmapReader;
1313
@class QMRootNode;
14-
@class QMFontConverter;
14+
@class QMFontManager;
1515

1616
/**
1717
* Helper class to build up the mindmap internally using event-driven xml reading and the class QMNode.

‎Qmind/QMProxyNode.m

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,12 @@
1010
#import "QMProxyNode.h"
1111
#import "QMNode.h"
1212
#import "QMMindmapReader.h"
13-
#import "QMFontConverter.h"
13+
#import "QMFontManager.h"
1414
#import "QMRootNode.h"
1515
#import "QMIdGenerator.h"
1616

1717
@implementation QMProxyNode {
18-
__weak QMFontConverter *_fontConverter;
18+
__weak QMFontManager *_fontConverter;
1919
__weak QMMindmapReader *_reader;
2020
__weak QMIdGenerator *_idGenerator;
2121

@@ -181,7 +181,7 @@ - (BOOL)isUnsupportedElement {
181181

182182
- (void)initDependencies {
183183
_reader = [[TBContext sharedContext] beanWithClass:[QMMindmapReader class]];
184-
_fontConverter = [[TBContext sharedContext] beanWithClass:[QMFontConverter class]];
184+
_fontConverter = [[TBContext sharedContext] beanWithClass:[QMFontManager class]];
185185
_idGenerator = [[TBContext sharedContext] beanWithClass:[QMIdGenerator class]];
186186
}
187187

‎QmindTest/FontConverterTest.m renamed to ‎QmindTest/QMFontManagerTest.m

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,14 @@
77
*/
88

99
#import "QMBaseTestCase.h"
10-
#import "QMFontConverter.h"
10+
#import "QMFontManager.h"
1111
#import "QMAppSettings.h"
1212
#import "QMCacaoTestCase.h"
1313

14-
@interface FontConverterTest : QMCacaoTestCase @end
14+
@interface QMFontManagerTest : QMCacaoTestCase @end
1515

16-
@implementation FontConverterTest {
17-
QMFontConverter *fontConverter;
16+
@implementation QMFontManagerTest {
17+
QMFontManager *fontConverter;
1818
NSFont *defaultFont;
1919

2020
NSFontManager *fontManager;
@@ -23,7 +23,7 @@ @implementation FontConverterTest {
2323
- (void)setUp {
2424
[super setUp];
2525

26-
fontConverter = [self.context beanWithClass:[QMFontConverter class]];
26+
fontConverter = [self.context beanWithClass:[QMFontManager class]];
2727
defaultFont = [[self.context beanWithClass:[QMAppSettings class]] settingForKey:qSettingDefaultFont];
2828
fontManager = [NSFontManager sharedFontManager];
2929
}

0 commit comments

Comments
 (0)
This repository has been archived.