Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify impact of datetime coordinate unit on polyfit, polyval, integrate, differentiate #9937

Open
dcherian opened this issue Jan 9, 2025 · 0 comments

Comments

@dcherian
Copy link
Contributor

dcherian commented Jan 9, 2025

What is your issue?

We will soon support non-nanosecond time units. There are a few functions whose output could rely on the spacing of coordinate values: polyfit , polyval, integrate, differentiate (are there any more?)

  1. integrate and differentiate take a datetime_unit kwarg, polyfit and polyval do not.
  2. polyfit and polyval force conversion to ns:
    data=datetime_to_numeric(x.data, offset=offset, datetime_unit="ns"),

We probably want to relax (2) in the future. Either way it would be good to systematically think about this and at least talk about it in the docstrings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant