Skip to content

Handling comments that have been resolved #446

Open
@ragingdave

Description

@ragingdave

After pushing a PR up that requires (for a number of reasons) a large number of style fixes, this could result in many 10s of comments. This is very tedious to go one by one and resolve when clearly pronto knows it already made a comment, and could very well determine which comments are still an issue or resolved.

I found this: https://github.com/Vasfed/pronto-github_resolver but it appears to only work with github (which is fine for my efforts), but it's rather old and using graphql to directly communicate with github all while not really being maintained (not that there's much to maintain).

Could that be something that is brought into this repo as a feature of pronto and the various formatters to handle auto resolving of comments?

Activity

Mayurifag

Mayurifag commented on Sep 29, 2023

@Mayurifag

Having kinda same problem, I guess.

Using GitLab, if you've fixed problems pronto stated in your PR, comments aren't deleted. There is way with forcepush of branch which is completely changed (i.e. squashed), but it doesnt satisfy me at all.

I wished to find way, that in every run of pronto, comments in PR related to pronto were automatically cleaned before run. Maybe alternative way is that if pronto errors were fixed (green pipeline), it will clean its comments then.

Did anyone find the way to solve this?

ashkulz

ashkulz commented on Jan 13, 2025

@ashkulz
Member

@ragingdave / @Mayurifag, would appreciate your feedback on #467 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @ashkulz@ragingdave@Mayurifag

        Issue actions

          Handling comments that have been resolved · Issue #446 · prontolabs/pronto