Update dependencies (#486)

Author: slimbuck

package-lock.json

@@ -52,7 +52,7 @@
         "jest": "^29.7.0",
         "jszip": "^3.10.1",
         "mp4-muxer": "^5.2.1",
-        "playcanvas": "^2.7.1",
+        "playcanvas": "^2.7.2",
         "postcss": "^8.5.3",
         "rollup": "^4.40.0",
         "rollup-plugin-scss": "^4.0.1",

package.json

@@ -177,7 +177,7 @@ class AssetLoader {
                     url: loadRequest.url,
                     filename: loadRequest.filename
                 });
-                asset.resource = new GSplatResource(this.app.graphicsDevice, gsplatData, []);
+                asset.resource = new GSplatResource(this.app, gsplatData, []);
                 resolve(new Splat(asset));
             })
             .catch((err) => {

src/asset-loader.ts

@@ -501,7 +501,7 @@ class Camera extends Element {
 
         const fdist = focalRadius / this.sceneRadius;
 
-        this.setDistance(isNaN(fdist) ? 1 : fdist, options?.speed ?? 0);
+        this.setDistance(isFinite(fdist) ? fdist : 1, options?.speed ?? 0);
         this.setFocalPoint(focalPoint, options?.speed ?? 0);
     }
 

src/camera.ts

@@ -792,9 +792,9 @@ const sortSplats = (splats: Splat[], indices: CompressedIndex[]) => {
                 const y = centers[i * 3 + 1];
                 const z = centers[i * 3 + 2];
 
-                const ix = Math.floor(1024 * (x - minx) / xlen);
-                const iy = Math.floor(1024 * (y - miny) / ylen);
-                const iz = Math.floor(1024 * (z - minz) / zlen);
+                const ix = Math.min(1023, Math.floor(1024 * (x - minx) / xlen));
+                const iy = Math.min(1023, Math.floor(1024 * (y - miny) / ylen));
+                const iz = Math.min(1023, Math.floor(1024 * (z - minz) / zlen));
 
                 morton[idx++] = encodeMorton3(ix, iy, iz);
             }
@@ -918,6 +918,13 @@ const serializePlyCompressed = async (splats: Splat[], options: SerializeSetting
             }
         }
 
+        // pad the end of the last chunk with duplicate data
+        if (num < 256) {
+            for (let j = num; j < 256; ++j) {
+                chunk.set(j, singleSplat);
+            }
+        }
+
         const result = chunk.pack();
 
         const off = chunkOffset + i * 18 * 4;

src/splat-serialize.ts

@@ -141,7 +141,7 @@ class Splat extends Element {
 
         // pack spherical harmonic data
         const createTexture = (name: string, format: number) => {
-            return new Texture(splatResource.device, {
+            return new Texture(splatResource.app.graphicsDevice, {
                 name: name,
                 width: width,
                 height: height,
@@ -159,7 +159,7 @@ class Splat extends Element {
         this.transformTexture = createTexture('splatTransform', PIXELFORMAT_R16U);
 
         // create the transform palette
-        this.transformPalette = new TransformPalette(splatResource.device);
+        this.transformPalette = new TransformPalette(splatResource.app.graphicsDevice);
 
         // blend mode for splats
         const blendState = new BlendState(true, BLENDEQUATION_ADD, BLENDMODE_ONE, BLENDMODE_ONE_MINUS_SRC_ALPHA);

src/splat.ts

@@ -24,7 +24,7 @@ class HistogramData {
         let min, max, i;
         for (i = 0; i < count; i++) {
             const v = valueFunc(i);
-            if (v !== undefined && !isNaN(v)) {
+            if (v !== undefined && isFinite(v)) {
                 min = max = v;
                 break;
             }
@@ -38,17 +38,16 @@ class HistogramData {
         // continue min/max calc
         for (; i < count; i++) {
             const v = valueFunc(i);
-            if (v !== undefined) {
+            if (v !== undefined && isFinite(v)) {
                 if (v < min) min = v; else if (v > max) max = v;
             }
         }
 
         // fill bins
         for (let i = 0; i < count; i++) {
             const v = valueFunc(i);
-            if (v !== undefined) {
+            if (v !== undefined && isFinite(v)) {
                 const n = min === max ? 0 : (v - min) / (max - min);
-                if (isNaN(n)) continue;
                 const bin = Math.min(bins.length - 1, Math.floor(n * bins.length));
                 if (selectedFunc(i)) {
                     bins[bin].selected++;