Skip to content

Missing required packages in setup/install documentation #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
acolwill opened this issue Apr 2, 2025 · 2 comments · Fixed by #457
Open

Missing required packages in setup/install documentation #455

acolwill opened this issue Apr 2, 2025 · 2 comments · Fixed by #457

Comments

@acolwill
Copy link

acolwill commented Apr 2, 2025

Describe the bug
Missing required packages in setup/install documentation

To Reproduce
Steps to reproduce the behavior:

  1. Install a "bare metal" RaspberryPi without desktop or other packages.
  2. Download PADD
  3. Run PADD to connect and display information against a separate PiHole instance.

Expected behavior
PADD should execute and show information

Additional context
Package "jq" is noted as being missing when PADD is first run.
"dig" is then noted as being missing when PADD is next run. This is part of the dnsutils package.

@mwoolweaver
Copy link
Contributor

mwoolweaver commented Apr 2, 2025

needs to be added here

PADD/padd.sh

Lines 1467 to 1478 in 47bd6c6

check_dependencies() {
# Check for required dependencies
if ! command -v curl >/dev/null 2>&1; then
printf "%b" "${check_box_bad} Error!\n 'curl' is missing but required.\n"
exit 1
fi
if ! command -v jq >/dev/null 2>&1; then
printf "%b" "${check_box_bad} Error!\n 'jq' is missing but required.\n"
exit 1
fi
}


could do something similar to #457

@acolwill
Copy link
Author

acolwill commented Apr 2, 2025

Just needs the install documentation updated with the requirements for jq, dig (dnstools) and curl on a minimal system.

mwoolweaver added a commit to mwoolweaver/PADD that referenced this issue Apr 2, 2025
mwoolweaver added a commit to mwoolweaver/PADD that referenced this issue Apr 2, 2025
@yubiuser yubiuser linked a pull request Apr 4, 2025 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants