Should showing PADD version require authenticating with Pi-hole?

[mwoolweaver]

Currently showing the version for PADD requires authenticating with Pi-hole.

To Reproduce
Steps to reproduce the behavior:

1. run ./padd.sh -v
2. see the following

./padd.sh -v
API not available. Please check server address and connectivity

Expected behavior
Unsure?? If only showing PADD version why is auth needed?

Additional context

When I checked the code I noticed there are checks for docker and such. Is this why authentication is required?

[rdwebdesign]

Well... the current padd -v output should show:

• currently installer PADD version;
• latest PADD version;
• docker tag (if installed in a container);
• latest docker tag (if installed in a container).

Before v4, PADD could only be installed on the same machine (or container) where Pi-hole was installed, so all this info was easily available.

Now, PADD v4.x can be installed on a different machine and it needs the API to return the Docker tag, if that's the case.

---

That said, I think this is unnecessarily complex.

In my personal opinion, the docker tag doesn't add too much value. Even the latest PADD version is probably unnecessary.
Sometimes showing less information is the best approach.

My suggestion would be to padd -v return only:
PADD v4.0 (or maybe PADD v4.0 (v4.1 available)).

[mwoolweaver]

My suggestion would be to padd -v return only:
PADD v4.0 (or maybe PADD v4.0 (v4.1 available)).

this is what i was thinking as well.

[yubiuser]

I agree. We could do it similarly to the changes to the update function

ca7dcfd

[mwoolweaver]

my attempt can be seen @ #462