Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The obsolete and insecure CKEditor 4 CDN should be replaced with an offline v5 version or replaced with a newer CDN editor #1062

Open
lwcorp opened this issue Jan 16, 2025 · 5 comments
Labels
3.7.x PRs for 3.7

Comments

@lwcorp
Copy link
Contributor

lwcorp commented Jan 16, 2025

Steps to reproduce
Edit a campaign

Required result
Get no warnings and don't risk your server.

Actual outcome

This CKEditor 4 version is not secure. Consider upgrading to the latest one. For more details, please check the browser console.

Image

The browser console produces:

This CKEditor 4.5.7 version is not secure. Consider upgrading to the latest one, 4.25.0-lts: https://ckeditor.com/ckeditor-4-support/

Image

Additional info
v4.5.7 is from almost a decade ago...while the latest free v4 is 4.22.1 which already became obsolete too. But v5's free CDN version is limited to 1,000 editor loads per month.

Interim solution
As per https://discuss.phplist.org/t/ckeditor-shows-warning-message-about-being-insecure/9621:

  1. Make sure you have the latest CKEditor plugin (if needed, upgrade manually using https://github.com/bramley/phplist-plugin-ckeditor/archive/master.zip)
  2. Use the last unlimited free CDN version in the settings: //cdn.ckeditor.com/4.22.1/full/ckeditor.js
    Image

This should buy some time, but it's not unlikely they'll remove this support one day (possibly when the commercial CKEditor 4 LTS version becomes obsolete too in December 2026).

@lwcorp lwcorp changed the title CKEditor is not secure CKEditor should be upgraded to v5 as the obsolete v4 is not secure Jan 16, 2025
@phpListDockerBot
Copy link
Contributor

This issue has been mentioned on phpList Discuss. There might be relevant details there:

https://discuss.phplist.org/t/ckeditor-shows-warning-message-about-being-insecure/9621/6

@lwcorp lwcorp changed the title CKEditor should be upgraded to v5 as the obsolete v4 is not secure CKEditor should be replaced with a fully free alternative instead of using the obsolete and insecure v4 Jan 16, 2025
@lwcorp lwcorp changed the title CKEditor should be replaced with a fully free alternative instead of using the obsolete and insecure v4 CKEditor 4 should be replaced with a fully free alternative instead of using an obsolete and insecure version Jan 16, 2025
@lwcorp lwcorp changed the title CKEditor 4 should be replaced with a fully free alternative instead of using an obsolete and insecure version The obsolete and insecure CKEditor 4 CDN should be replaced with an offline v5 version or replaced with a newer CDN editor Jan 16, 2025
@michield
Copy link
Member

Yes, that needs updating.

@michield
Copy link
Member

@bramley can I just check? I think this warrants a new plugin "CKeditor5". Are you working on that, or shall I get going?

@bramley
Copy link
Contributor

bramley commented Jan 18, 2025

The CKEditor 5 is not compatible with CKEditor 4 so it is not a case of simply "upgrading" it. I have had a go at modifying the plugin but it wasn't straightforward. I hacked something together using code samples from the documentation that does display the CKEditor 5 but it doesn't include a file manager to upload and select images. I don't know how or even if the kcfinder file manager can be incorporated. That too is obsolete.

Image

I am actually quite happy using the current plugin with CKEditor 4 as it meets my needs. Also, because phplist uses CKEditor only within the admin interface and also in a very restricted way I think that the security issues are minimal.

@michield michield added the 3.7.x PRs for 3.7 label Jan 18, 2025
@lwcorp
Copy link
Contributor Author

lwcorp commented Jan 19, 2025

Are plugins auto updated? If not, maybe consider for the time being to at least present administrators a link to both update the plugin and the URL of ckeditor.js.

But again, all of this just buys time. CKEditor is likely to eventually drop that v4 URL altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.7.x PRs for 3.7
Projects
None yet
Development

No branches or pull requests

4 participants