-
-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The obsolete and insecure CKEditor 4 CDN should be replaced with an offline v5 version or replaced with a newer CDN editor #1062
Comments
This issue has been mentioned on phpList Discuss. There might be relevant details there: https://discuss.phplist.org/t/ckeditor-shows-warning-message-about-being-insecure/9621/6 |
Yes, that needs updating. |
@bramley can I just check? I think this warrants a new plugin "CKeditor5". Are you working on that, or shall I get going? |
The CKEditor 5 is not compatible with CKEditor 4 so it is not a case of simply "upgrading" it. I have had a go at modifying the plugin but it wasn't straightforward. I hacked something together using code samples from the documentation that does display the CKEditor 5 but it doesn't include a file manager to upload and select images. I don't know how or even if the kcfinder file manager can be incorporated. That too is obsolete. I am actually quite happy using the current plugin with CKEditor 4 as it meets my needs. Also, because phplist uses CKEditor only within the admin interface and also in a very restricted way I think that the security issues are minimal. |
Are plugins auto updated? If not, maybe consider for the time being to at least present administrators a link to both update the plugin and the But again, all of this just buys time. CKEditor is likely to eventually drop that v4 URL altogether. |
Steps to reproduce
Edit a campaign
Required result
Get no warnings and don't risk your server.
Actual outcome
The browser console produces:
Additional info
v4.5.7 is from almost a decade ago...while the latest free v4 is 4.22.1 which already became obsolete too. But v5's free CDN version is limited to 1,000 editor loads per month.
Interim solution
As per https://discuss.phplist.org/t/ckeditor-shows-warning-message-about-being-insecure/9621:
//cdn.ckeditor.com/4.22.1/full/ckeditor.js
This should buy some time, but it's not unlikely they'll remove this support one day (possibly when the commercial CKEditor 4 LTS version becomes obsolete too in December 2026).
The text was updated successfully, but these errors were encountered: