Skip to content

Commit 4b86cfe

Browse files
committed
fix test blocking
1 parent 30cecc4 commit 4b86cfe

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

test/test_extension.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -337,7 +337,7 @@ def test_privileged_extension(self):
337337
args = p.get_docker_args(mock_cliargs)
338338
self.assertTrue('--privileged' in args)
339339

340-
340+
@pytest.mark.skipif(sys.platform.startswith("win"), reason="User mapping not supported on Windows")
341341
class UserExtensionTest(unittest.TestCase):
342342

343343
def setUp(self):
@@ -351,7 +351,6 @@ def setUp(self):
351351
# "em.Error: interpreter stdout proxy lost"
352352
em.Interpreter._wasProxyInstalled = False
353353

354-
@pytest.mark.skipif(sys.platform.startswith("win"), "User mapping not supported on Windows")
355354
def test_user_extension(self):
356355
import pwd
357356

@@ -471,6 +470,7 @@ def test_user_collisions(self):
471470
dig.clear_image()
472471

473472

473+
@pytest.mark.skipif(sys.platform.startswith("win"), reason="Pulse not supported on Windows")
474474
class PulseExtensionTest(unittest.TestCase):
475475

476476
def setUp(self):
@@ -519,6 +519,7 @@ def test_pulse_extension(self):
519519
&& apt-get clean
520520
"""
521521

522+
@pytest.mark.skipif(sys.platform.startswith("win"), reason="DevHelper not supported on Windows")
522523
class DevHelpersExtensionTest(unittest.TestCase):
523524

524525
def setUp(self):

test/test_nvidia.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434

3535

3636
@pytest.mark.docker
37-
@pytest.mark.skipif(sys.platform.startswith("win"), "X11 not supported on Windows")
37+
@pytest.mark.skipif(sys.platform.startswith("win"), reason="X11 not supported on Windows")
3838
class X11Test(unittest.TestCase):
3939
@classmethod
4040
def setUpClass(self):
@@ -95,7 +95,6 @@ def test_x11_extension_nocleanup(self):
9595
# TODO(tfoote) do more to check that it doesn't actually clean up.
9696
# This is more of a smoke test
9797

98-
@pytest.mark.skipif(sys.platform.startswith("win"), "X11 not supported on Windows")
9998
def test_no_x11_xpdyinfo(self):
10099
for tag in self.dockerfile_tags:
101100
dig = DockerImageGenerator([], {}, tag)
@@ -114,7 +113,7 @@ def test_x11_xpdyinfo(self):
114113

115114

116115
@pytest.mark.docker
117-
@pytest.mark.skipif(sys.platform.startswith("win"), "NVIDIA not supported on Windows")
116+
@pytest.mark.skipif(sys.platform.startswith("win"), reason="NVIDIA not supported on Windows")
118117
class NvidiaTest(unittest.TestCase):
119118
@classmethod
120119
def setUpClass(self):

0 commit comments

Comments
 (0)