-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding more format? #57
Comments
Thank you for the suggestion! I would like the plugin to support various JSON log formats commonly used in the real world out of the box. If you have any example of JSON logs that are not supported by the plugin yet, please share them with me. I will try to add support for them. It would be helpful if you could also provide the information about the log library and its configuration.
Yes, custom format configurations would be useful. However, I believe that zero configuration is an important feature of the plugin. I would like to support as many log formats as possible before implementing custom configurations. |
Hello! Sorry to interrupt, I have a same opinion as reporter. I'am using logback with customizing field names. please refer to below my case! message > log_message If user can customise the field in your plugin it would be very thankful for our team Thank you! |
@top1436 Thank you for the feedback! I would consider adding a feature to customize field names. However, I would like to better understand the use case. What does your team customize field names for? If you have software that requires such keys, I would like to support them out of the box. |
Maybe its just what the org names things because other things are
configured to extract specific keys or is adhoc e.g. what they want to type
in. You probably cant support them all as there is no standard being
followed as inhouse or manually configured json structures could be used,
as I found there was a conflict between message as a string and message as
an object to have a message.description I had to put it first.
Adding a custom key path config may help to resolve this, rather than hard
coding the options make an array or split string by commas or just an
override that could be set for project and/or user config?
I was able to modify and compile to get it working by editing the
code/definitions. However, not all projects are configured the same.
Having a way to explicitly specify the keys would be helpful and probably
faster than searching a larger list of unused keys per message as this
could get more expensive the more combinations added.
…On Wed, 21 Aug 2024, 10:48 pm orangain, ***@***.***> wrote:
@top1436 <https://github.com/top1436> Thank you for the feedback! I would
consider adding a feature to customize field names. However, I would like
to better understand the use case. What does your team customize field
names for? If you have software that requires such keys, I would like to
support them out of the box.
—
Reply to this email directly, view it on GitHub
<#57 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAPAP3O7RXLDRJUKL6ABVJDZSRWA5AVCNFSM6AAAAABMPN4L7WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBRG42TEMZYGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@LiamKarlMitchell I understood the situation. Even if I were to implement a customizable configuration, without knowing what kind of logs you want to parse, I cannot determine how much flexibility to give the configuration. It would be very helpful if you could give me an example of the actual logs you would like to parse. |
It would be super cool if the plugin could also support logfmt formatted log lines as well where the log basically consists of
lines. A very simple RL example i.e. looks like this:
Here folding could also be indicated with either It would be nice if the plugin could also replace |
@RovoMe That's an interesting idea! Although the plugin is named as Pretty JSON Log, it might be reasonable to support other structured log formats. Since the topic of this issue is custom JSON format, could you please create a new issue for the logfmt support? I would like to consider details there. |
Hi @orangain. We're using LogstashEncoder, and the lib doesn't parse exceptions
I don't really care about other stuff, but having exception in the console normally logged is essential. Also the problem is when it doesn't parse the log, it just shows {...} which is not explicit enough, that there is some log that couldn't be parsed. Should probably show first 100 symbols, or something like that. |
Is it possible to add more
For instance logs in some software im working on are using json logs from spring boot with logback.
The fields/keys to pull message or error or timestamp from may have different names/paths.
This may very well be a custom format not sure. But a way to configure the relevant keys per project to use including a custom path would be great to have...
The text was updated successfully, but these errors were encountered: