Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Remove JSON files & fix activity thumbnails #5663

Open
BenHenning opened this issue Jan 23, 2025 · 0 comments
Open

[Feature Request]: Remove JSON files & fix activity thumbnails #5663

BenHenning opened this issue Jan 23, 2025 · 0 comments
Assignees
Labels
enhancement End user-perceivable enhancements. Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet.

Comments

@BenHenning
Copy link
Member

Is your feature request related to a problem? Please describe.

With #5652 and the removal of Gradle, we no longer need to support loading JSON lesson files.

Describe the solution you'd like

Removal of all JSOn lesson files and corresponding JSON loading code, along with removal of any gating code/logic across the codebase (i.e. LoadLessonProtosFromAssets can be completely removed).

Note that while the clean-up is straightforward, we can't actually move forward with this change without also fixing the fact that thumbnails do not load correctly with proto files. This needs to be fixed properly as well (ideally by introducing some sort of dev-specific override for loading certain thumbnails so that we can force them to be local, dev-only versions).

Describe alternatives you've considered

There's not a strong alternative for the JSON clean-up as proto is the predominant format the app will be using for lessons moving forward. However, the exact approach for fixing the thumbnail issue is unclear, and there are likely many alternative solutions possible.

Additional context

No response

@BenHenning BenHenning added enhancement End user-perceivable enhancements. triage needed labels Jan 23, 2025
@TanishMoral11 TanishMoral11 self-assigned this Jan 30, 2025
@adhiamboperes adhiamboperes added Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. labels Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement End user-perceivable enhancements. Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet.
Development

No branches or pull requests

4 participants