-
Notifications
You must be signed in to change notification settings - Fork 94
Migrate to PEP 517/660 by adding pyproject.toml
and replacing legacy setup.py
develop
#861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@Bischoff can i work on this , if there is any |
@Eeshu-Yadav first, a word of caution: if you plan to apply for the Linux Foundation mentorship projects, be aware that contributing to the project will bring you no advantage with respect to the other candidates. We have seen last year candidates investing some time in the project, and then getting disappointed they did not get selected. Don't do that. If you do a PR, do it only for your own fun and for the sake of the project, there's no reward. Second, thanks for the issue. I am a python noob and don't understand the technical details, nor how difficult it is to do what you suggest. Maybe @aazam-gh has a better grip than me. But modernizing the framework seems very legitimate to me. Technically, after a build done with your PR, the packaging workflow must still be working. The packaging code resides at https://github.com/mfcloud/build-zvmsdk. If you need some changes to the spec files so the packaging still works after your changes, please coordinate with Aazam. Ping @mfriesenegger for awareness. |
@Eeshu-Yadav Thank you for raising this issue. This was a point of discussion last summer during the packaging of Feilong. This would require a lot of testing, particularly for all 3 of our major distributions (Ubuntu, SLES, RHEL). You are more than welcome to raise a PR with the updated |
hii @Bischoff , as someone interested in the project , both for contributing and under LFX , could you guide me on what is important in the proposal as PRs are not? It would be of great help. |
@kairveeehh The first step would be to migrate the setup to the |
@aazam-gh working on that , will raise the pr soon |
@Eeshu-Yadav please note that this will not affect your mentorship selection. |
Could you guide me over the things which would matter apart from the proposal? |
@kairveeehh Sorry for answering that late, I had 2 terrible weeks. The mentorship selection process is already closed. It has been done on the base of the resumes and cover letters (preselection), then with online interviews. @Eeshu-Yadav if you are still interested in doing a PR, we would be glad to have one. And if you don't have the time, it's okay too, It was nice to describe accurately this issue in a card. Thank you! |
No worries , thanks for the reply!
|
I wish you good luck for next year!
It's just standard face-to-face job interviews, but over video. |
@Bischoff will work on it |
@Eeshu-Yadav I'm happy to assist you with this issue. |
Uh oh!
There was an error while loading. Please reload this page.
Summary
The current installation method relies on the legacy
setup.py develop
for editable installs. This approach is deprecated and will be removed in future versions ofpip
(starting with pip 25.1).Suggested Fix
Migrate the project to use
pyproject.toml
with PEP 517 and PEP 660, which supports modern editable installations usingpip install -e .
.Tasks
pyproject.toml
with the build system and project metadata.dev
dependencies inpyproject.toml
.requirements.txt
andtox.ini
.setup.py
after migration is stable.pip install -e .[dev] --use-pep517
.Benefits
References
Happy to help with a PR if needed!
The text was updated successfully, but these errors were encountered: