-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: Enable auth by default for Swarm #744
Comments
What do you think about allowing the user to create own credentials by passing them as arguments to |
It is a valid suggestion, but I'd rather not complicate things at this stage. The secret can be updated easily with the |
For Kubernetes, we could include the Caddy basic auth ingress object in the helm template. As described in @stefanprodan 's blog post: https://stefanprodan.com/2017/openfaas-kubernetes-ingress-ssl-gke/ |
There is no more need for Caddy since the OpenFaaS Gateway implements basic auth. For Kubernetes I've added the basic auth option to the Helm chart https://github.com/openfaas/faas-netes/tree/master/chart/openfaas#secure-the-gateway-administrative-api-and-ui-with-basic-auth |
That's right - @ericstoekl the change made in the gateway implements basic authentication directly. See the PR #743 and try it out. |
Derek set milestone: 0.8.6 |
Derek close: resolved |
For Docker Swarm we should enable basic auth by default.
We don't want users deploying OpenFaaS with public IPs and having that open to the world.
Since we use a shell script to deploy I think we can automate this with bash.
First attempt #743
Feedback/suggestions/ideas welcome
Alex
The text was updated successfully, but these errors were encountered: