Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Enable auth by default for Swarm #744

Closed
alexellis opened this issue Jul 3, 2018 · 7 comments
Closed

Proposal: Enable auth by default for Swarm #744

alexellis opened this issue Jul 3, 2018 · 7 comments
Assignees
Milestone

Comments

@alexellis
Copy link
Member

For Docker Swarm we should enable basic auth by default.

We don't want users deploying OpenFaaS with public IPs and having that open to the world.

Since we use a shell script to deploy I think we can automate this with bash.

First attempt #743

Feedback/suggestions/ideas welcome

Alex

@ivanayov
Copy link
Contributor

ivanayov commented Jul 6, 2018

What do you think about allowing the user to create own credentials by passing them as arguments to deploy_stack.sh (or some better approach for the same)?

@alexellis
Copy link
Member Author

It is a valid suggestion, but I'd rather not complicate things at this stage. The secret can be updated easily with the docker secret command. Please see the suggestions on the PR and feel free to comment on those too.

@ericstoekl
Copy link
Contributor

For Kubernetes, we could include the Caddy basic auth ingress object in the helm template. As described in @stefanprodan 's blog post: https://stefanprodan.com/2017/openfaas-kubernetes-ingress-ssl-gke/

@stefanprodan
Copy link
Contributor

There is no more need for Caddy since the OpenFaaS Gateway implements basic auth. For Kubernetes I've added the basic auth option to the Helm chart https://github.com/openfaas/faas-netes/tree/master/chart/openfaas#secure-the-gateway-administrative-api-and-ui-with-basic-auth

@alexellis
Copy link
Member Author

That's right - @ericstoekl the change made in the gateway implements basic authentication directly. See the PR #743 and try it out.

@alexellis alexellis self-assigned this Jul 9, 2018
@alexellis
Copy link
Member Author

Derek set milestone: 0.8.6

@derek derek bot added this to the 0.8.6 milestone Jul 13, 2018
@alexellis
Copy link
Member Author

Derek close: resolved

@derek derek bot closed this as completed Jul 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants