Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bottom spy isn't great with short pages #222

Open
skolverket-jonmar opened this issue Jan 10, 2020 · 1 comment
Open

Bottom spy isn't great with short pages #222

skolverket-jonmar opened this issue Jan 10, 2020 · 1 comment

Comments

@skolverket-jonmar
Copy link

The bottom spy functionality is great for taller pages with the last element being too short to reach the offset, but for pages where the content always reaches the bottom of the page the last element will always be active. And clicking the other elements in the navlist doesn't do anything, the last element stays active anyway. That doesn't do great UX. At least make the clicked element active though it doesn't result in any scrolling (due to the page always reaching the bottom).

Another problem this results in is that when entering the page the last navlist element is automatically active, which doesn't make sense since the user hasn't chosen to be navigated to the last element. The first element should be active if the user hasn't chosen anything else.

It just seems messy to start coding around these problems, but has anyone else had the same problem and solved it in any way?

@skolverket-jonmar
Copy link
Author

Worthy of adding is that my pages are dynamically rendered so some are short and some tall, they vary a lot in structure which makes it difficult to ugly hack a solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant