Skip to content

Commit 80969d7

Browse files
Merge pull request #66 from therealansh/patch-1
fix: bulk api response type
2 parents 259d728 + 744b899 commit 80969d7

File tree

3 files changed

+9
-7
lines changed

3 files changed

+9
-7
lines changed

src/main/kotlin/api/EventsApi.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ interface EventsApi {
2121
suspend fun triggerEvent(@Body body: TriggerEventRequest): Response<ResponseWrapper<TriggerResponse>>
2222

2323
@POST("$ENDPOINT/trigger/bulk")
24-
suspend fun bulkTriggerEvent(@Body body: BulkTriggerEventRequest): Response<ResponseWrapper<TriggerResponse>>
24+
suspend fun bulkTriggerEvent(@Body body: BulkTriggerEventRequest): Response<ResponseWrapper<List<TriggerResponse>>>
2525

2626
@POST("$ENDPOINT/trigger/broadcast")
2727
suspend fun broadcastEvent(@Body body: BroadcastEventRequest): Response<ResponseWrapper<TriggerResponse>>

src/main/kotlin/extensions/EventsExtensions.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ suspend fun Novu.trigger(body: TriggerEventRequest): ResponseWrapper<TriggerResp
1616
return response.extractResponse(logger)
1717
}
1818

19-
suspend fun Novu.bulkTrigger(body: BulkTriggerEventRequest): ResponseWrapper<TriggerResponse>? {
19+
suspend fun Novu.bulkTrigger(body: BulkTriggerEventRequest): ResponseWrapper<List<TriggerResponse>>? {
2020
val response = eventsApi.bulkTriggerEvent(body)
2121
return response.extractResponse(logger)
2222
}

src/test/kotlin/EventsApiTest.kt

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -97,11 +97,13 @@ class EventsApiTest {
9797
@Test
9898
fun testBulkTriggerEvent() = runTest {
9999
val responseBody = ResponseWrapper(
100-
TriggerResponse(
101-
acknowledged = true,
102-
status = "status",
103-
transactionId = "transactionId",
104-
error = listOf("error")
100+
listOf(
101+
TriggerResponse(
102+
acknowledged = true,
103+
status = "status",
104+
transactionId = "transactionId",
105+
error = listOf("error")
106+
)
105107
)
106108
)
107109
mockWebServer.enqueue(

0 commit comments

Comments
 (0)