conda-forge package?

[keewis]

Would you be interested in maintaining a conda-forge feedstock for h3ronpy?

I'm currently trying to package xdggs, which depends on h3ronpy.

Obviously, I volunteer to help, should you need any.

[kylebarron]

You should be able to follow the conda-forge recipe in https://github.com/conda-forge/arro3-core-feedstock or https://github.com/conda-forge/geoindex-rs-feedstock. Anyone can make the feedstock. You can make a PR like conda-forge/staged-recipes#28081 or conda-forge/staged-recipes#27289 if you want to get the ball rolling. And then you can cc me and potentially add both nmandery and me as recipe maintainers if you'd like

[nmandery]

Personally I do not use conda-forge so I am not in a good position to maintain such a package. Contributions are welcome of course.

+1 for Kyles proposal

[keewis]

Anyone can make the feedstock.

Sure, I just wanted to ask first.

In any case, see conda-forge/staged-recipes#28385. I have zero experience with packaging rust+python packages, so there might still be additional things to do (but at least CI and the linters passed). For example, the h3arrow crate might need its own package?

I've added the two of you as co-maintainers of the recipe, could I ask you to accept (or reject) by posting a comment on that PR?

Finally, I've noticed several potential issues in h3ronpy's pyproject.toml (but again, there might be a good rust+python-specific reason for those that I'm not seeing): there's no requires-python entry (the release summary of 0.22.0 says the lower bound is python=3.9), and there's also no lower bound on numpy in the dependencies.

[keewis]

the PR is merged, so we now have the package on conda-forge, so we should be able to close this.

As mentioned in the PR, while initially you're not listed as one, feel free to request being added as a maintainer either here or on the feedstock whenever you want, @nmandery.

For the issues in pyproject.toml above, is this something you'd say is common for Rust-based python projects or just an oversight?

[kylebarron]

I think it would be fine (and proper) to add requires-python to the pyproject.toml. I'm not sure what the minimum numpy version would be; I doubt h3ronpy uses any recent numpy features.

[kylebarron]

Perhaps we should add a conda-forge badge to the readme, next to the pypi version badge. And maybe add a line for conda install to the docs? https://h3ronpy.readthedocs.io/en/latest/installation.html

[nmandery]

Thanks everybody for putting work into providing the conda package - I just added the links Kyle suggested.

I probably forgot about the minimum python version in the pyproject.toml - I normally just adjust the Github-Action workflow to build for whatever is the oldest, non-end-of-life, python version.

Regarding the numpy version h3ronpy just uses very basic features which have been in numpy for a long time. No idea what this version would be ;)

[kylebarron]

In this situation when I don't know the most recent breaking change I use, I go back a few years... maybe 3 years? and choose whatever numpy version was released then.

[keewis]

there's a scientific python-wide spec for recommended versions (which numpy endorsed): SPEC0. According to that, the current lower bound would be numpy>=1.24.

You don't have to follow it, but I think it can serve as a good guideline.

[nmandery]

Thanks @keewis for pointing this out - I set the package metadata accordingly.