disable self-update for windows versions below 17763 (#177)

Author: uubulb

model/config.go

@@ -13,6 +13,7 @@ import (
 	"github.com/knadh/koanf/v2"
 	"sigs.k8s.io/yaml"
 
+	"github.com/nezhahq/agent/pkg/logger"
 	"github.com/nezhahq/agent/pkg/util"
 )
 
@@ -76,10 +77,19 @@ func (c *AgentConfig) Read(path string) error {
 		return err
 	}
 
+	if !c.DisableAutoUpdate || !c.DisableForceUpdate {
+		if util.IsBelow10() {
+			c.DisableAutoUpdate = true
+			c.DisableForceUpdate = true
+			logger.Println("This version of Windows is no longer supported, disabling self-update now")
+			defer saveOnce()
+		}
+	}
+
 	if c.UUID == "" {
 		if uuid, err := uuid.GenerateUUID(); err == nil {
 			c.UUID = uuid
-			saveOnce()
+			defer saveOnce()
 		} else {
 			return fmt.Errorf("generate UUID failed: %v", err)
 		}

pkg/pty/pty_windows.go

@@ -9,20 +9,19 @@ import (
 	"os"
 	"os/exec"
 	"path/filepath"
-	"regexp"
 	"runtime"
-	"strconv"
 
 	"github.com/UserExistsError/conpty"
 	"github.com/artdarek/go-unzip"
 	"github.com/iamacarpet/go-winpty"
-	"github.com/shirou/gopsutil/v4/host"
+
+	"github.com/nezhahq/agent/pkg/util"
 )
 
 var _ IPty = (*winPTY)(nil)
 var _ IPty = (*conPty)(nil)
 
-var isWin10 = VersionCheck()
+var isWin10 = !util.IsBelow10()
 
 type winPTY struct {
 	tty *winpty.WinPTY
@@ -32,27 +31,6 @@ type conPty struct {
 	tty *conpty.ConPty
 }
 
-func VersionCheck() bool {
-	hi, err := host.Info()
-	if err != nil {
-		return false
-	}
-
-	re := regexp.MustCompile(`Build (\d+(\.\d+)?)`)
-	match := re.FindStringSubmatch(hi.KernelVersion)
-	if len(match) > 1 {
-		versionStr := match[1]
-
-		version, err := strconv.ParseFloat(versionStr, 64)
-		if err != nil {
-			return false
-		}
-
-		return version >= 17763
-	}
-	return false
-}
-
 func DownloadDependency() error {
 	if isWin10 {
 		return nil

pkg/util/util.go

@@ -6,10 +6,13 @@ import (
 	"net"
 	"net/http"
 	"os"
+	"regexp"
+	"strconv"
 	"strings"
 	"sync"
 
 	jsoniter "github.com/json-iterator/go"
+	"github.com/shirou/gopsutil/v4/host"
 	"github.com/shirou/gopsutil/v4/process"
 )
 
@@ -147,3 +150,24 @@ func SubUintChecked[T Unsigned](a, b T) T {
 type Unsigned interface {
 	~uint | ~uint8 | ~uint16 | ~uint32 | ~uint64
 }
+
+func IsBelow10() bool {
+	hi, err := host.Info()
+	if err != nil {
+		return true
+	}
+
+	re := regexp.MustCompile(`Build (\d+(\.\d+)?)`)
+	match := re.FindStringSubmatch(hi.KernelVersion)
+	if len(match) > 1 {
+		versionStr := match[1]
+
+		version, err := strconv.ParseFloat(versionStr, 64)
+		if err != nil {
+			return true
+		}
+
+		return version < 17763
+	}
+	return true
+}