feat(editor): Support partial executions of tool nodes (#14945)

Author: schrothbn

packages/cli/src/__tests__/load-nodes-and-credentials.test.ts

@@ -318,6 +318,7 @@ describe('LoadNodesAndCredentials', () => {
 				group: ['input'],
 				inputs: [],
 				outputs: ['ai_tool'],
+				usableAsTool: true,
 				properties: [
 					{
 						default: 'A test node',
@@ -370,6 +371,7 @@ describe('LoadNodesAndCredentials', () => {
 				inputs: [],
 				outputs: ['ai_tool'],
 				description: 'A test node',
+				usableAsTool: true,
 				properties: [
 					{
 						displayName: 'Description',

packages/cli/src/load-nodes-and-credentials.ts

@@ -317,6 +317,8 @@ export class LoadNodesAndCredentials {
 						} as INodeTypeBaseDescription)
 					: deepCopy(usableNode);
 			const wrapped = this.convertNodeToAiTool({ description }).description;
+			// TODO: Remove this when we support partial execution on all tool nodes
+			wrapped.usableAsTool = true;
 
 			this.types.nodes.push(wrapped);
 			this.known.nodes[wrapped.name] = { ...this.known.nodes[usableNode.name] };

packages/frontend/editor-ui/src/components/FromAiParametersModal.test.ts

@@ -0,0 +1,198 @@
+import { createTestingPinia } from '@pinia/testing';
+import { createComponentRenderer } from '@/__tests__/render';
+import FromAiParametersModal from '@/components/FromAiParametersModal.vue';
+import { FROM_AI_PARAMETERS_MODAL_KEY, STORES } from '@/constants';
+import userEvent from '@testing-library/user-event';
+import { useWorkflowsStore } from '@/stores/workflows.store';
+import { useParameterOverridesStore } from '@/stores/parameterOverrides.store';
+import { useRouter } from 'vue-router';
+import { NodeConnectionTypes } from 'n8n-workflow';
+
+const ModalStub = {
+	template: `
+		<div>
+			<slot name="header" />
+			<slot name="title" />
+			<slot name="content" />
+			<slot name="footer" />
+		</div>
+	`,
+};
+
+vi.mock('vue-router');
+
+vi.mocked(useRouter);
+
+const mockNode = {
+	id: 'id1',
+	name: 'Test Node',
+	parameters: {
+		testBoolean: "={{ $fromAI('testBoolean', ``, 'boolean') }}",
+		testParam: "={{ $fromAi('testParam',  ``, 'string') }}",
+	},
+};
+
+const mockParentNode = {
+	name: 'Parent Node',
+};
+
+const mockRunData = {
+	data: {
+		resultData: {
+			runData: {
+				['Test Node']: [
+					{
+						inputOverride: {
+							[NodeConnectionTypes.AiTool]: [[{ json: { testParam: 'override' } }]],
+						},
+					},
+				],
+			},
+		},
+	},
+};
+
+const mockWorkflow = {
+	id: 'test-workflow',
+	getChildNodes: () => ['Parent Node'],
+};
+
+const renderModal = createComponentRenderer(FromAiParametersModal);
+let pinia: ReturnType<typeof createTestingPinia>;
+let workflowsStore: ReturnType<typeof useWorkflowsStore>;
+let parameterOverridesStore: ReturnType<typeof useParameterOverridesStore>;
+describe('FromAiParametersModal', () => {
+	beforeEach(() => {
+		pinia = createTestingPinia({
+			initialState: {
+				[STORES.UI]: {
+					modalsById: {
+						[FROM_AI_PARAMETERS_MODAL_KEY]: {
+							open: true,
+							data: {
+								nodeName: 'Test Node',
+							},
+						},
+					},
+					modalStack: [FROM_AI_PARAMETERS_MODAL_KEY],
+				},
+				[STORES.WORKFLOWS]: {
+					workflow: mockWorkflow,
+					workflowExecutionData: mockRunData,
+				},
+			},
+		});
+		workflowsStore = useWorkflowsStore();
+		workflowsStore.getNodeByName = vi
+			.fn()
+			.mockImplementation((name: string) => (name === 'Test Node' ? mockNode : mockParentNode));
+		workflowsStore.getCurrentWorkflow = vi.fn().mockReturnValue(mockWorkflow);
+		parameterOverridesStore = useParameterOverridesStore();
+		parameterOverridesStore.clearParameterOverrides = vi.fn();
+		parameterOverridesStore.addParameterOverrides = vi.fn();
+		parameterOverridesStore.substituteParameters = vi.fn();
+	});
+
+	it('renders correctly with node data', () => {
+		const { getByTitle } = renderModal({
+			props: {
+				modalName: FROM_AI_PARAMETERS_MODAL_KEY,
+				data: {
+					nodeName: 'Test Node',
+				},
+			},
+			global: {
+				stubs: {
+					Modal: ModalStub,
+				},
+			},
+			pinia,
+		});
+
+		expect(getByTitle('Test Test Node')).toBeTruthy();
+	});
+
+	it('uses run data when available as initial values', async () => {
+		const { getByTestId } = renderModal({
+			props: {
+				modalName: FROM_AI_PARAMETERS_MODAL_KEY,
+				data: {
+					nodeName: 'Test Node',
+				},
+			},
+			global: {
+				stubs: {
+					Modal: ModalStub,
+				},
+			},
+			pinia,
+		});
+
+		await userEvent.click(getByTestId('execute-workflow-button'));
+
+		expect(parameterOverridesStore.addParameterOverrides).toHaveBeenCalledWith(
+			'test-workflow',
+			'id1',
+			{
+				testBoolean: true,
+				testParam: 'override',
+			},
+		);
+	});
+
+	it('clears parameter overrides when modal is executed', async () => {
+		const { getByTestId } = renderModal({
+			props: {
+				modalName: FROM_AI_PARAMETERS_MODAL_KEY,
+				data: {
+					nodeName: 'Test Node',
+				},
+			},
+			global: {
+				stubs: {
+					Modal: ModalStub,
+				},
+			},
+			pinia,
+		});
+
+		await userEvent.click(getByTestId('execute-workflow-button'));
+
+		expect(parameterOverridesStore.clearParameterOverrides).toHaveBeenCalledWith(
+			'test-workflow',
+			'id1',
+		);
+	});
+
+	it('adds substitutes for parameters when executed', async () => {
+		const { getByTestId } = renderModal({
+			props: {
+				modalName: FROM_AI_PARAMETERS_MODAL_KEY,
+				data: {
+					nodeName: 'Test Node',
+				},
+			},
+			global: {
+				stubs: {
+					Modal: ModalStub,
+				},
+			},
+			pinia,
+		});
+
+		const inputs = getByTestId('from-ai-parameters-modal-inputs');
+		await userEvent.click(inputs.querySelector('input[value="testBoolean"]') as Element);
+		await userEvent.clear(inputs.querySelector('input[name="testParam"]') as Element);
+		await userEvent.type(inputs.querySelector('input[name="testParam"]') as Element, 'given value');
+		await userEvent.click(getByTestId('execute-workflow-button'));
+
+		expect(parameterOverridesStore.addParameterOverrides).toHaveBeenCalledWith(
+			'test-workflow',
+			'id1',
+			{
+				testBoolean: false,
+				testParam: 'given value',
+			},
+		);
+	});
+});