Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[charts] Review legend vs label classes #16102

Open
JCQuintas opened this issue Jan 8, 2025 · 0 comments
Open

[charts] Review legend vs label classes #16102

JCQuintas opened this issue Jan 8, 2025 · 0 comments
Assignees
@JCQuintas
Labels
component: charts This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature

Comments

@JCQuintas
Copy link
Member

I got confused by the fact the legend and the legend item are two distinct components with different classes objects.

Here we are in the legend so we can only target the mark (MuiChartsLegend-mark). We need to use the labelMark to target what is inside.

That's not super intuitive, but it's another debate which will be more interesting when we will create demos about how to create custom shape like for example

image

Originally posted by @alexfauquette in #15733 (comment)
@JCQuintas JCQuintas self-assigned this Jan 8, 2025
@JCQuintas JCQuintas added enhancement This is not a bug, nor a new feature component: charts This is the name of the generic UI component, not the React module! labels Jan 8, 2025
@JCQuintas JCQuintas mentioned this issue Jan 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JCQuintas JCQuintas

Labels
component: charts This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JCQuintas