-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Autocomplete] Accessibility issues with keyboard navigation Autocomplete #44936
Comments
Hi @martha, Thank you for raising these accessibility concerns! It would have been better to create separate issues for each. However, it's fine now. Here’s a response to each point: A) This is expected behavior. Please refer to #30815 and the combobox ARIA pattern:
B) Pressing Enter on a selected option deselects (removes) it. This is intentional, as it provides a way to remove an option using the keyboard. Without this, keyboard users would lack a mechanism to remove selections. C) I couldn’t fully understand the reproduction steps, especially:
Could you clarify or provide more details about this step? D) This is expected behavior. The Tab key (or Shift + Tab) is intended to move focus between inputs, not chips. See #18150 (comment) for additional context. Navigation within chips is supported via Arrow Left/Right keys. Thanks for bringing these up! Let us know if you need further clarification. |
Thank you so much @ZeeshanTamboli ! A) Sorry I missed that someone had already created a related issue. I have a follow-up question. The Combobox WAI docs that you linked don't seem to mention the Clear button, only the Popup indicator. Maybe I am missing something, but I wasn't able to find any aria docs that indicate that a Clear button should not be included in the page tab sequence. Do you have a link to such docs? B) Here, I also wasn't able to find aria docs indicating that this would be expected behavior. The Combobox docs describe the following behavior on enter:
This doesn't mention removing the accepted (selected) value if it is already accepted. To me, this seems related to A. If there were a keyboard-accessible way to access the Clear button, overloading the 'Enter' behavior in this confusing way would not be needed. C) Yes! I'm sorry for the lack of clarity. Here is what I meant by "Using VO, ctrl-option(or capslock)-left to select an option and delete."
Let me know if this helps! D) Thanks again for the link to the prior conversation, and sorry that I missed it before! (I should have searched the closed issues more carefully.) On this, I'm also wondering whether you have links to any aria docs that describe this behavior as desirable. Thank you very much for your time on this! |
A) I couldn't find any official documentation, only discussions:
Since there’s no official documentation (or none I could find), this might be worth considering. B) You might be right—this could be an accessibility issue. C) I can’t test on Mac, as I use Windows OS. D) Again, there’s no official documentation, only prior discussions. I’ll keep this issue open to address accessibility concerns. |
Steps to reproduce
A) In Autocomplete, the Clear button is not accessible by keyboard. To reproduce:
Expected: Focus moves to the now-visible Clear button
Current: Focus moves out of the example
My workaround:
However, with this workaround, the clear button can only be activated with Space. Ideally, it would be activated with either Space or Enter.
B) In Autocomplete with Multi, pressing Enter when focused on a selected dropdown element causes the element to get deleted. To reproduce:
Current: The selected option is deleted from the selection.
Expected: My expectation is that the dropdown would close, and the selected option would stay selected. (But perhaps this is intended behavior?)
C) In Autocomplete with Multi, when navigating with Voiceover, after deleting an option, focus returns to the document body. To reproduce:
Current: Focus shifts to the document body
Expected: Focus remains on the autocomplete component. (Perhaps this a bug with VO, not MUI?)
D) In Autocomplete with Multi, users should be able to tab around the selected options. To reproduce:
Expected: Focus moves to the option chips
Current: Focus moves out of the example. Option chips can only be focused using left-right arrows. Relates to other issues with chip accessibility #20470, but I think this is a separate problem specific to chips within Autocomplete.
Current behavior
No response
Expected behavior
No response
Context
Hi MUI maintainers! While my team was auditing our app's accessibility, we came across a few things that we thought were accessibility problems within the Autocomplete component. Since we couldn't find existing issues for these, we wanted to create an issue to discuss with you. Let us know, which ones of these are desired behavior, which you'd consider bugs, and which may be fixed with the upcoming work on #25365!
I'll add the caveat that we are not screenreader users, ourselves.
This is my first time creating an issue in the MUI repo. Please let me know if anything else would be helpful. Thanks!
Related issues:
Your environment
Tested using examples in the current MUI docs (see links above), using VoiceOver on Chrome.
Search keywords: accessibility autocomplete
The text was updated successfully, but these errors were encountered: