fix: don't read data for inverter on/off switch

Author: mkuthan

custom_components/solis_cloud_control/entity.py

@@ -34,7 +34,7 @@ def __init__(
 
     @property
     def available(self) -> bool:
-        if not super().available:
+        if not self.coordinator.last_update_success:
             return False
 
         for cid in self.cids:

custom_components/solis_cloud_control/inverters/inverter.py

@@ -346,9 +346,7 @@ def create_hybrid_inverter(
     def all_cids(self) -> list[int]:
         cids: list[int] = []
 
-        if self.on_off:
-            cids.append(self.on_off.on_cid)
-            cids.append(self.on_off.off_cid)
+        # CIDs for on-off are write-only, so they are not included
         if self.storage_mode:
             cids.append(self.storage_mode.cid)
         if self.charge_discharge_settings:

custom_components/solis_cloud_control/switch.py

@@ -110,6 +110,13 @@ def __init__(
         self._attr_is_on = True
         self._attr_assumed_state = True
 
+    @property
+    def available(self) -> bool:
+        if not self.coordinator.last_update_success:
+            return False
+        # CIDs for on-off are write only, skip availability check based on coordinator data
+        return True
+
     async def async_turn_on(self, **kwargs: dict[str, any]) -> None:  # noqa: ARG002
         _LOGGER.info("Turning on inverter")
         await self.coordinator.control_no_check(self.on_off.on_cid, self.on_off.on_value)

tests/test_entity.py

@@ -45,3 +45,13 @@ def test_available_multiple_cids(
         )
         mock_coordinator.data = coordinator_data
         assert entity.available == expected_available
+
+    def test_available_when_coordinator_unavailable(self, mock_coordinator):
+        entity = SolisCloudControlEntity(
+            coordinator=mock_coordinator,
+            entity_description=EntityDescription(key="any_key", name="any name"),
+            cids=1,
+        )
+
+        entity.coordinator.last_update_success = False
+        assert entity.available is False

tests/test_switch.py

@@ -27,6 +27,13 @@ def test_init(self, on_off_switch):
         assert on_off_switch.is_on is True
         assert on_off_switch.assumed_state is True
 
+    def test_available(self, on_off_switch):
+        assert on_off_switch.available is True
+
+    def test_available_when_coordinator_unavailable(self, on_off_switch):
+        on_off_switch.coordinator.last_update_success = False
+        assert on_off_switch.available is False
+
     async def test_turn_on(self, on_off_switch):
         await on_off_switch.async_turn_on()
         on_off_switch.coordinator.control_no_check.assert_awaited_once_with(