Skip to content

Commit a5cce4c

Browse files
chore: resolve build issues and add rush change files
1 parent e3647d3 commit a5cce4c

File tree

5 files changed

+38
-5
lines changed

5 files changed

+38
-5
lines changed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
{
2+
"changes": [
3+
{
4+
"packageName": "@microsoft/rush",
5+
"comment": "",
6+
"type": "none"
7+
}
8+
],
9+
"packageName": "@microsoft/rush"
10+
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
{
2+
"changes": [
3+
{
4+
"packageName": "@rushstack/heft",
5+
"comment": "Require a logging name for every operation.",
6+
"type": "patch"
7+
}
8+
],
9+
"packageName": "@rushstack/heft"
10+
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
{
2+
"changes": [
3+
{
4+
"packageName": "@rushstack/operation-graph",
5+
"comment": "Require a logging name for every operation.",
6+
"type": "patch"
7+
}
8+
],
9+
"packageName": "@rushstack/operation-graph"
10+
}

libraries/operation-graph/src/WatchLoop.ts

+7-4
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ export class WatchLoop implements IWatchLoopState {
156156

157157
const requestRunMessage: IRequestRunEventMessage = {
158158
event: 'requestRun',
159-
requestor
159+
requester
160160
};
161161

162162
tryMessageHost(requestRunMessage);
@@ -192,9 +192,12 @@ export class WatchLoop implements IWatchLoopState {
192192

193193
try {
194194
status = await this.runUntilStableAsync(abortController.signal);
195-
this._requestRunPromise.finally(() => {
196-
requestRunFromHost('runIPCAsync');
197-
});
195+
this._requestRunPromise
196+
// the reject callback in the promise is discarded so we ignore errors
197+
.catch(() => {})
198+
.finally(() => {
199+
requestRunFromHost('runIPCAsync');
200+
});
198201
} catch (err) {
199202
status = OperationStatus.Failure;
200203
return reject(err);

libraries/rush-lib/src/logic/operations/IPCOperationRunner.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ export class IPCOperationRunner implements IOperationRunner {
103103

104104
this._ipcProcess.on('message', (message: unknown) => {
105105
if (isRequestRunEventMessage(message)) {
106-
this._requestRun(message.requestor);
106+
this._requestRun(message.requester);
107107
} else if (isSyncEventMessage(message)) {
108108
resolveReadyPromise();
109109
}

0 commit comments

Comments
 (0)