Skip to content

Commit 586f4e2

Browse files
committed
Setup PLACKUP_ARGS at run time
1 parent 2cf3d03 commit 586f4e2

File tree

3 files changed

+3
-7
lines changed

3 files changed

+3
-7
lines changed

.github/workflows/build-production-container.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ jobs:
4747
with:
4848
build-args: |
4949
APP_ENV=poduction
50-
HOST_PORT=5055
50+
HOST_PORT=3000
5151
PLACKUP_ARGS='-E production -s Starman --workers=10 -l /tmp/app.sock'
5252
push: true
5353
tags: ${{ steps.meta.outputs.tags }}

Dockerfile

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,11 @@ WORKDIR /metacpan-grep-front-end
3333

3434
# Build arguments
3535
ARG APP_ENV=development
36+
ARG PLACKUP_ARGS="--port 3000"
3637

3738
# Runtime
3839
ENV APP_ENV=$APP_ENV
40+
ENV PLACKUP_ARGS=$PLACKUP_ARGS
3941

4042
# .dockerignore is used to exclude files from the build context
4143
COPY src/ ./

src/lib/GrepCpan/Grep.pm

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -460,12 +460,6 @@ sub current_version($self) {
460460
'-',
461461
$grepcpan::VERSION,
462462
'cache' => $self->config()->{'cache'}->{'version'},
463-
'grep' => eval {
464-
scalar Git::Repository->new(
465-
work_tree => $self->config()->{'gitrepo'},
466-
{ git => $self->git_binary }
467-
)->run(qw{rev-parse --short HEAD});
468-
} // '',
469463
'cpan' =>
470464
eval { scalar $self->git->run(qw{rev-parse --short HEAD}) }
471465
// '',

0 commit comments

Comments
 (0)