-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch package manager to pnpm
#1660
Comments
Hello, I saw discussion here, but I answer in this issue for an easier traceability with community: I'm not sure this change is worth it. We would like to keep what is working and yarn is not deprecated and still widely used. We want to avoid pain and work in order to focus on the most critical things. I'm afraid of the new pains this huge change could bring. However I agree with you @flevi29, updating yarn could be a good move Would love to have the opinion of the community of this |
I'm not so sure about this huge pain and work. I detailed in the PR in my last comment that this will not be the case because of how Anyhow, the way I see it, to upgrade you'll still need to change |
Alright fair enough, switching to |
Closed in favour of #1664. |
Updated description. |
I know @curquiza and @brunoocasali have some concerns, so I'll share my feedback regarding moving to PNPM here. Why migrate from Yarn? First of all, the yarn version we are using has entered maintenance mode. Eventually it will reach EOL and we will have to migrate to a new Yarn version. The different versions of Yarn have different ways to resolve dependencies, create different lockfiles, and don't interoperate particularly well in my experience. So a migration will be needed at some point anyway. Why PNPM? Generally speaking, I'm in favor of moving to PNPM because it makes the lives of maintainers easier. As Flevi pointed out, it's now a common tool for front-end libraries, and I have more experience with it than I do with Yarn. My main selling points for PNPM are:
I'm not saying this is a priority, but it would be a welcome improvement to our workflows. |
A lot of high profile repositories these days use
pnpm
, for instance:I was looking into upgrading Yarn, but it looks like to make full use of the latest Yarn, we'd have to make some trade-offs and non-standard changes.
Instead I will be switching to
pnpm
, and I will do so for every JS/TS repository in the meilisearch org, if you'll allow me.The text was updated successfully, but these errors were encountered: