Skip to content

Java is a dependency #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aduh95 opened this issue Oct 16, 2017 · 3 comments
Closed

Java is a dependency #17

aduh95 opened this issue Oct 16, 2017 · 3 comments

Comments

@aduh95
Copy link

aduh95 commented Oct 16, 2017

Maybe I am stating the obvious here, but I think you should include a note in the README saying that Java is required in order to generate any plantuml; it's even more important than installing Graphviz, which has a note and is not even required.

I had users on my library (which depends on yours) complaining about crashing on their configuration, because java was not available on their path.

Error: spawn java ENOENT
    at _errnoException (util.js:1021:11)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:192:19)
    at onErrorNT (internal/child_process.js:374:16)
    at _combinedTickCallback (internal/process/next_tick.js:138:11)
    at process._tickCallback (internal/process/next_tick.js:180:9)
error Command failed with exit code 1.
@ThaDaVos
Copy link

This is still an issue - a colleague of mine didn't have it installed and the error isn't really clear - maybe catch the error and show a message that Java isn't installed instead?

@markushedvall
Copy link
Owner

Regarding the unclear error message it will be handled in issue #7

An error must be thrown regardless, but the error output should be better.

@aduh95
Copy link
Author

aduh95 commented Aug 21, 2019

The real issue with the current implementation is that the error is not catchable by the implementer, it crashes the whole Node process. And I agree the error could be clearer, but it's not as big as an issue IMHO.

Closing in favor of #7.

@aduh95 aduh95 closed this as completed Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants