You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Maybe I am stating the obvious here, but I think you should include a note in the README saying that Java is required in order to generate any plantuml; it's even more important than installing Graphviz, which has a note and is not even required.
I had users on my library (which depends on yours) complaining about crashing on their configuration, because java was not available on their path.
Error: spawn java ENOENT
at _errnoException (util.js:1021:11)
at Process.ChildProcess._handle.onexit (internal/child_process.js:192:19)
at onErrorNT (internal/child_process.js:374:16)
at _combinedTickCallback (internal/process/next_tick.js:138:11)
at process._tickCallback (internal/process/next_tick.js:180:9)
error Command failed with exit code 1.
The text was updated successfully, but these errors were encountered:
This is still an issue - a colleague of mine didn't have it installed and the error isn't really clear - maybe catch the error and show a message that Java isn't installed instead?
The real issue with the current implementation is that the error is not catchable by the implementer, it crashes the whole Node process. And I agree the error could be clearer, but it's not as big as an issue IMHO.
Maybe I am stating the obvious here, but I think you should include a note in the README saying that Java is required in order to generate any plantuml; it's even more important than installing Graphviz, which has a note and is not even required.
I had users on my library (which depends on yours) complaining about crashing on their configuration, because
java
was not available on their path.The text was updated successfully, but these errors were encountered: