Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting multiple messages concurrently makes all disappear when first message is deleted #10246

Open
Cathy0123456789 opened this issue Feb 2, 2025 · 1 comment
Assignees
Labels
bug communication Pull requests that affect the corresponding module

Comments

@Cathy0123456789
Copy link

Describe the bug

When deleting multiple messages one after another, all messages disappear at the same time or shortly after the timer for Undo deletion runs out for the first message

Communication.2025-02-02.17-47-19.mp4

To Reproduce

  1. Go to the Communication tab
  2. Write multiple messages into a channel
  3. Delete a message
  4. After few seconds & before the Undo timer runs out, delete at least one more message
  5. See the following message(s) disappear before their own timer runs out

Expected behavior

Each message gets deleted when their own timer runs out

Screenshots

No response

Which version of Artemis are you seeing the problem on?

7.9.0

What browsers are you seeing the problem on?

Microsoft Edge

Additional context

No response

Relevant log output

@Cathy0123456789 Cathy0123456789 added bug communication Pull requests that affect the corresponding module labels Feb 2, 2025
@github-actions github-actions bot added the lecture Pull requests that affect the corresponding module label Feb 2, 2025
@Cathy0123456789 Cathy0123456789 removed the lecture Pull requests that affect the corresponding module label Feb 2, 2025
@badkeyy badkeyy self-assigned this Feb 5, 2025
@badkeyy
Copy link
Contributor

badkeyy commented Feb 6, 2025

The bug occurs because, during its deconstruction, a posting checks whether the deletion process has already started. If it has, the posting deletes itself immediately. This behavior is designed to handle scenarios where a user deletes a posting and then immediately switches pages, causing the posting to be removed instantly. However, if the posting belongs to a view group, it is also deconstructed when the group is recreated—this happens because the original group of a posting has been deleted and a new one is created for the posting. Therefore the page switch check wrongfully returns true and the 2nd posting deletes itself instantly... Not quite sure how differentiate this two scenarios so I would highly appreciate some thoughts...

Edit: I found a way: #10283

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug communication Pull requests that affect the corresponding module
Projects
Status: Todo
Development

No branches or pull requests

2 participants