refactor

Author: uyab

src/Avatar.php

@@ -110,7 +110,7 @@ public function create($name)
 
         $this->initialGenerator->setName($name);
         $this->initialGenerator->setLength($this->chars);
-        $this->initials = $this->initialGenerator->getInitial();
+        $this->initials = $this->initialGenerator->make();
 
         $this->setForeground($this->getRandomForeground());
         $this->setBackground($this->getRandomBackground());

src/InitialGenerator.php

@@ -72,7 +72,7 @@ public function setUppercase($uppercase)
         $this->uppercase = $uppercase;
     }
 
-    public function getInitial()
+    public function make()
     {
         $words = new Collection(explode(' ', $this->name));
 

tests/AvatarLaravelTest.php

@@ -23,7 +23,7 @@ public function it_can_override_attributes_when_instantiated()
         $cache = Mockery::mock('Illuminate\Contracts\Cache\Repository');
 
         $generator = Mockery::mock('Laravolt\Avatar\InitialGenerator');
-        $generator->shouldReceive('getInitial')->andReturn('AB');
+        $generator->shouldReceive('make')->andReturn('AB');
         $generator->shouldReceive('setUppercase');
         $generator->shouldReceive('setAscii');
 
@@ -51,7 +51,7 @@ public function it_can_override_attributes_after_set_name()
         $generator = Mockery::mock('Laravolt\Avatar\InitialGenerator');
         $generator->shouldReceive('setName')->andReturnSelf();
         $generator->shouldReceive('setLength');
-        $generator->shouldReceive('getInitial')->andReturn('A');
+        $generator->shouldReceive('make')->andReturn('A');
         $generator->shouldReceive('setUppercase');
         $generator->shouldReceive('setAscii');
         $generator->shouldReceive('base_path');
@@ -86,7 +86,7 @@ public function it_has_correct_random_background()
         $generator->shouldReceive('setLength')->andReturn(1);
         $generator->shouldReceive('setName')->andReturn($name);
         $generator->shouldReceive('setUppercase')->andReturnSelf();
-        $generator->shouldReceive('getInitial')->andReturn('A');
+        $generator->shouldReceive('make')->andReturn('A');
         $avatar->create($name);
 
         $this->assertAttributeEquals('#000000', 'background', $avatar);
@@ -113,7 +113,7 @@ public function it_has_different_random_background()
 
         $generator->shouldReceive('setLength')->andReturn(2);
         $generator->shouldReceive('setName')->andReturn($name1);
-        $generator->shouldReceive('getInitial')->andReturn('AA');
+        $generator->shouldReceive('make')->andReturn('AA');
 
         $avatar1 = new \Laravolt\Avatar\Avatar($config, $cache, $generator);
         $avatar1->create($name1);

tests/InitialsGeneratorTest.php

@@ -10,7 +10,7 @@ public function it_accept_string()
     {
         $generator = new \Laravolt\Avatar\InitialGenerator('Bayu Hendra');
 
-        $this->assertEquals('BH', $generator->getInitial());
+        $this->assertEquals('BH', $generator->make());
     }
 
     /**
@@ -20,7 +20,7 @@ public function it_accept_stringy()
     {
         $generator = new \Laravolt\Avatar\InitialGenerator(new \Stringy\Stringy('Bayu Hendra'));
 
-        $this->assertEquals('BH', $generator->getInitial());
+        $this->assertEquals('BH', $generator->make());
     }
 
     /**
@@ -48,7 +48,7 @@ public function it_can_generate_initials_from_single_word_name()
     {
         $generator = new \Laravolt\Avatar\InitialGenerator('Fulan');
 
-        $this->assertEquals('Fu', (string) $generator->getInitial());
+        $this->assertEquals('Fu', (string) $generator->make());
     }
 
     /**
@@ -58,7 +58,7 @@ public function it_can_generate_initials_from_multi_word_name()
     {
         $generator = new \Laravolt\Avatar\InitialGenerator('Fulan Doe');
 
-        $this->assertEquals('FD', (string) $generator->getInitial());
+        $this->assertEquals('FD', (string) $generator->make());
     }
 
     /**
@@ -69,7 +69,7 @@ public function it_can_generate_initials_if_name_shorter_than_expected_length()
         $generator = new \Laravolt\Avatar\InitialGenerator('Joe');
         $generator->setLength(4);
 
-        $this->assertEquals('Joe', (string) $generator->getInitial());
+        $this->assertEquals('Joe', (string) $generator->make());
     }
 
     /**
@@ -80,7 +80,7 @@ public function it_can_generate_initials_if_name_longer_than_expected_length()
         $generator = new \Laravolt\Avatar\InitialGenerator('Fulan John Doe');
         $generator->setLength(2);
 
-        $this->assertEquals('FJ', (string) $generator->getInitial());
+        $this->assertEquals('FJ', (string) $generator->make());
     }
 
     /**
@@ -90,7 +90,7 @@ public function it_can_handle_empty_name()
     {
         $generator = new \Laravolt\Avatar\InitialGenerator('');
 
-        $this->assertEquals('', (string) $generator->getInitial());
+        $this->assertEquals('', (string) $generator->make());
     }
 
     /**
@@ -100,7 +100,7 @@ public function it_allow_non_ascii()
     {
         $generator = new \Laravolt\Avatar\InitialGenerator('Bāyu');
 
-        $this->assertEquals('Bā', (string) $generator->getInitial());
+        $this->assertEquals('Bā', (string) $generator->make());
     }
 
     /**
@@ -111,7 +111,7 @@ public function it_can_convert_to_ascii()
         $generator = new \Laravolt\Avatar\InitialGenerator('Bāyu');
         $generator->setAscii(true);
 
-        $this->assertEquals('Ba', (string) $generator->getInitial());
+        $this->assertEquals('Ba', (string) $generator->make());
     }
 
     /**
@@ -120,12 +120,12 @@ public function it_can_convert_to_ascii()
     public function it_can_generate_initials_from_email()
     {
         $generator = new \Laravolt\Avatar\InitialGenerator('[email protected]');
-        $this->assertEquals('ab', $generator->getInitial());
+        $this->assertEquals('ab', $generator->make());
 
         $generator = new \Laravolt\Avatar\InitialGenerator('[email protected]');
-        $this->assertEquals('ci', $generator->getInitial());
+        $this->assertEquals('ci', $generator->make());
 
         $generator = new \Laravolt\Avatar\InitialGenerator('[email protected]');
-        $this->assertEquals('DA', $generator->getInitial());
+        $this->assertEquals('DA', $generator->make());
     }
 }