Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why download notification disappears when pause? #4207

Closed
kelson42 opened this issue Feb 1, 2025 · 5 comments · Fixed by #4210
Closed

Why download notification disappears when pause? #4207

kelson42 opened this issue Feb 1, 2025 · 5 comments · Fixed by #4210
Assignees
Milestone

Comments

@kelson42
Copy link
Collaborator

kelson42 commented Feb 1, 2025

It should not IMHO

@kelson42 kelson42 added this to the 3.14.0 milestone Feb 1, 2025
@kelson42 kelson42 added the bug label Feb 1, 2025
@salehdemir
Copy link

Can you please assign me this issue ?

@MohitMaliFtechiz
Copy link
Collaborator

MohitMaliFtechiz commented Feb 3, 2025

It disappears because Fetch removes the notification when a download is paused(and this feature was working like this in previous versions of the application) there is no clear reason behind it, but I believe that because we don't know when the user will resume the download Fetch removes the notification of Download when we pause the download to avoid the extra handling of notifications in the pause state. There is an issue open for this in the Fetch repo tonyofrancis/Fetch#575.

But we can create our custom logic to show the notification when downloading is paused.

@salehdemir
Copy link

@MohitMaliFtechiz
Thank you for the explanation! I understand that Fetch removes the notification when a download is paused to avoid extra handling, but since there's an open issue for this (tonyofrancis/Fetch#575), I'd like to work on it by implementing a custom logic to show the notification in the paused state.

I will start by exploring how Fetch manages notifications internally and see how we can extend or override this behavior. If you have any suggestions on where to begin or specific areas of the codebase I should focus on, I'd appreciate your guidance.

@MohitMaliFtechiz
Copy link
Collaborator

MohitMaliFtechiz commented Feb 3, 2025

@salehdemir Thanks for showing interest, but this issue is very important to our downloading functionality, and we have the foreground service as well for the downloading functionality. So let me handle this issue. You can take other issues.

You can take issues from the next milestone which are easy to implement https://github.com/kiwix/kiwix-android/issues?q=is%3Aissue%20state%3Aopen%20milestone%3A3.15.0%20

@kelson42
Copy link
Collaborator Author

kelson42 commented Feb 5, 2025

@MohitMaliDeveloper Please ensure the pause button does not remove the notification

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants