Skip to content

Commit fe78f61

Browse files
authored
Merge pull request #43 from jupyter-naas/workspace-grpc
fix: Build grpc for workspace
2 parents 92c33cf + 19deab6 commit fe78f61

File tree

16 files changed

+580
-42
lines changed

16 files changed

+580
-42
lines changed

Makefile

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,13 @@ protoc=$(d) protoc
33

44
generate: clean python go build submodules
55
docker compose run --rm -it python
6-
cd python/naas_models && sed -i.bak 's/import validate_pb2/import naas_models.validate_pb2/g' *.py && rm *.bak
7-
cd python/naas_models/pydantic && sed -i.bak 's/common_p2p/naas_models.pydantic.common_p2p/g' *.py && rm *.bak
8-
cd python/naas_models/pydantic && sed -i.bak 's/errors_p2p/naas_models.pydantic.errors_p2p/g' *.py && rm *.bak
6+
echo "Patching python files"
7+
sed -i.bak -r 's/^(import )([a-zA-Z]*_pb2)/import naas_models.\2/g' python/naas_models/*.py && rm python/naas_models/*.bak
8+
sed -i.bak -r 's/^(import )([a-zA-Z]*_pb2)/import naas_models.pydantic.\2/g' python/naas_models/pydantic/*.py && rm python/naas_models/pydantic/*.bak
9+
sed -i.bak -r 's/^(from )([a-zA-Z]*_p2p)/from naas_models.pydantic.\2/g' python/naas_models/pydantic/*.py && rm python/naas_models/pydantic/*.bak
10+
# cd python/naas_models && sed -i.bak 's/import validate_pb2/import naas_models.validate_pb2/g' *.py && rm *.bak
11+
# cd python/naas_models/pydantic && sed -i.bak 's/common_p2p/naas_models.pydantic.common_p2p/g' *.py && rm *.bak
12+
# cd python/naas_models/pydantic && sed -i.bak 's/errors_p2p/naas_models.pydantic.errors_p2p/g' *.py && rm *.bak
913

1014
build:
1115
docker compose build
@@ -22,7 +26,7 @@ go:
2226
mkdir go
2327

2428
clean:
25-
rm -rf dist go python/naas_models/*_pb2.py python/naas_models/pydantic/*_p2p.py
29+
rm -rf dist go python/naas_models/*_pb2*.py python/naas_models/pydantic/*_p2p.py python/naas_models/*.pyi
2630

2731
submodules:
2832
git submodule init && git submodule update

docker-compose.yaml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,4 +19,10 @@ services:
1919
--python_out=../python/naas_models \
2020
--go_out=../go \
2121
--validate_out="lang=go:../go" \
22-
space.proto registry.proto iam.proto aimodel.proto chat.proto credit.proto secret.proto storage.proto workspace.proto asset.proto errors.proto validate.proto ontology.proto common.proto p2p_validate.proto
22+
space.proto registry.proto iam.proto aimodel.proto chat.proto credit.proto secret.proto storage.proto workspace.proto asset.proto errors.proto validate.proto ontology.proto common.proto p2p_validate.proto && \
23+
poetry run python3 -m grpc_tools.protoc \
24+
-I=../protos/ \
25+
-I=../lib/protoc-gen-validate/validate/ \
26+
--pyi_out=../python/naas_models \
27+
--grpc_python_out=../python/naas_models \
28+
workspace.proto

go/github.com/jupyter-naas/naas-models/go/iam/iam.pb.go

Lines changed: 14 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

go/github.com/jupyter-naas/naas-models/go/iam/iam.pb.validate.go

Lines changed: 4 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

go/github.com/jupyter-naas/naas-models/go/workspace/workspace.pb.go

Lines changed: 8 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

protos/iam.proto

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ message TokenData {
1111
optional string user_id = 1;
1212
repeated string scopes = 2;
1313
optional string api_key_id = 3;
14+
optional string jwt_token = 4;
1415
}
1516

1617
message Profile {

protos/workspace.proto

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -295,4 +295,8 @@ message WorkspaceWipeRequest {
295295

296296
message WorkspaceWipeResponse {
297297
optional errors.ErrorResponse error = 1;
298+
}
299+
300+
service WorkspaceService {
301+
rpc ListUser (WorkspaceUserListRequest) returns (WorkspaceUserListResponse);
298302
}

python/naas_models/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
from .pydantic.registry_p2p import *
1+
from naas_models.pydantic.registry_p2p import *

python/naas_models/asset_pb2.py

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)