Skip to content

Commit dd15fbe

Browse files
Andreas Fridlundsergeyklay
Andreas Fridlund
authored andcommitted
Add PHP 8.4 support
1 parent 39e35bc commit dd15fbe

File tree

7 files changed

+11
-11
lines changed

7 files changed

+11
-11
lines changed

src/Jaeger/Config.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -87,9 +87,9 @@ public function getLogger()
8787
*/
8888
public function __construct(
8989
array $config,
90-
string $serviceName = null,
91-
LoggerInterface $logger = null,
92-
CacheItemPoolInterface $cache = null
90+
?string $serviceName = null,
91+
?LoggerInterface $logger = null,
92+
?CacheItemPoolInterface $cache = null
9393
) {
9494
$this->config = $config;
9595

src/Jaeger/Reporter/LoggingReporter.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ class LoggingReporter implements ReporterInterface
2121
*
2222
* @param LoggerInterface|null $logger
2323
*/
24-
public function __construct(LoggerInterface $logger = null)
24+
public function __construct(?LoggerInterface $logger = null)
2525
{
2626
$this->logger = $logger ?? new NullLogger();
2727
}

src/Jaeger/ScopeManager.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ public function getActive(): ?OTScope
3838
* Sets the scope as active.
3939
* @param OTScope|null $scope
4040
*/
41-
public function setActive(OTScope $scope = null)
41+
public function setActive(?OTScope $scope = null)
4242
{
4343
$this->active = $scope;
4444
}

src/Jaeger/Sender/JaegerSender.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,8 +66,8 @@ class JaegerSender implements SenderInterface
6666
*/
6767
public function __construct(
6868
AgentIf $agentClient,
69-
LoggerInterface $logger = null,
70-
SpanToJaegerMapper $mapper = null
69+
?LoggerInterface $logger = null,
70+
?SpanToJaegerMapper $mapper = null
7171
) {
7272
$this->agentClient = $agentClient;
7373
$this->logger = $logger ?? new NullLogger();

src/Jaeger/Sender/UdpSender.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ class UdpSender
6262
public function __construct(
6363
AgentClient $client,
6464
int $maxBufferLength,
65-
LoggerInterface $logger = null
65+
?LoggerInterface $logger = null
6666
) {
6767
$this->client = $client;
6868
$this->maxBufferLength = $maxBufferLength;

src/Jaeger/ThriftUdpTransport.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ class ThriftUdpTransport extends TTransport
3636
* @param int $port
3737
* @param LoggerInterface $logger
3838
*/
39-
public function __construct(string $host, int $port, LoggerInterface $logger = null, Config $config = null)
39+
public function __construct(string $host, int $port, ?LoggerInterface $logger = null, ?Config $config = null)
4040
{
4141
$this->setLogger($logger);
4242

src/Jaeger/Tracer.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,8 +96,8 @@ public function __construct(
9696
ReporterInterface $reporter,
9797
SamplerInterface $sampler,
9898
$oneSpanPerRpc = true,
99-
LoggerInterface $logger = null,
100-
ScopeManager $scopeManager = null,
99+
?LoggerInterface $logger = null,
100+
?ScopeManager $scopeManager = null,
101101
$traceIdHeader = TRACE_ID_HEADER,
102102
$baggageHeaderPrefix = BAGGAGE_HEADER_PREFIX,
103103
$debugIdHeader = DEBUG_ID_HEADER_KEY,

0 commit comments

Comments
 (0)