Skip to content

edit package files in place #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jbolda opened this issue Apr 10, 2022 · 0 comments
Open

edit package files in place #236

jbolda opened this issue Apr 10, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@jbolda
Copy link
Owner

jbolda commented Apr 10, 2022

Currently, the package files (and changelogs) are parsed into a representation such as an AST, mutated and converted back. This relies on the library we are using to round trip non-destructively, that is, do this process without changing parts of the file that we didn't modify.

We want to look at possibly editing the string directly, and kind of shimming in our change instead. We can perhaps still use this libraries to help, but not depend on them doing a round trip. This should address many of the issues we are seeing and major versions of dependencies changing expectations.

@jbolda jbolda added the enhancement New feature or request label Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant