Skip to content

Commit 1090afd

Browse files
authored
feat: typescript going green (#153)
* initial command types * configure rollup * adding rollup, packages and various bumps for types * type up @covector/apply * type up @covector/changelog * adjust typings on command and files * type up @covector/assemble * type covector * extend root tsconfig * package file love * adjust workflows to build first * update change file * redo the node12 fs compat in covector init * fix node12 vs 14 fs import * strip existing action dist * exclude tests in rollup config * bump rollup * covector index not needed anymore * runCommand is not an iterator * type up covector a bit more * switch action to typescript * remove unneeded rollup config / plugins * don't need to build action before test * tsconfig should ignore fixtures * not an issue locally
1 parent 4683e0b commit 1090afd

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

78 files changed

+39298
-74534
lines changed

.changes/config.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@
108108
"path": "./packages/action",
109109
"manager": "javascript",
110110
"build": false,
111-
"preversion": "yarn build",
111+
"preversion": "yarn pkg",
112112
"publish": false,
113113
"getPublishedVersion": false,
114114
"dependencies": ["covector"],

.changes/covector-ts.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
---
22
"covector": minor
3+
"@covector/apply": minor
4+
"@covector/assemble": minor
5+
"@covector/changelog": minor
6+
"@covector/command": minor
37
"@covector/files": minor
48
---
59

.github/workflows/run-status.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,8 @@ jobs:
1010
with:
1111
fetch-depth: 0
1212
- run: yarn
13-
- run: yarn workspace action build
13+
- run: yarn build
14+
- run: yarn workspace action pkg
1415
- name: covector status
1516
uses: ./packages/action
1617
id: covector

.github/workflows/run-version-or-publish.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,8 @@ jobs:
2121
git config --global user.name "${{ github.event.pusher.name }}"
2222
git config --global user.email "${{ github.event.pusher.email }}"
2323
- run: yarn
24-
- run: yarn workspace action build
24+
- run: yarn build
25+
- run: yarn workspace action pkg
2526
- name: covector version-or-publish
2627
uses: ./packages/action
2728
id: covector

.github/workflows/test.yml

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ on:
33
pull_request:
44
push:
55
branches:
6-
- main
6+
- main
77

88
jobs:
99
test:
@@ -16,8 +16,5 @@ jobs:
1616
steps:
1717
- uses: actions/checkout@v2
1818
- run: yarn
19-
- name: covector build
20-
uses: ./packages/action
21-
with:
22-
command: build
19+
- run: yarn build
2320
- run: yarn test

__fixtures__/changelog.js-single-exists/CHANGELOG.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22

33
## [0.8.16]
44

5-
- Adds a command line interface option to tauri apps, configurable under tauri.conf.json > tauri > cli.
6-
- Fixes no-server mode not running on another machine due to fs::read_to_string usage instead of the include_str macro.
7-
Build no longer fails when compiling without environment variables, now the app will show an error.
8-
- Adds desktop notifications API.
9-
- Properly reflect tauri.conf.json changes on app when running tauri dev.
5+
- Adds a command line interface option to tauri apps, configurable under tauri.conf.json > tauri > cli.
6+
- Fixes no-server mode not running on another machine due to fs::read_to_string usage instead of the include_str macro.
7+
- Build no longer fails when compiling without environment variables, now the app will show an error.
8+
- Adds desktop notifications API.
9+
- Properly reflect tauri.conf.json changes on app when running tauri dev.

package.json

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
"license": "Apache-2.0",
88
"scripts": {
99
"covector": "node ./packages/covector/bin/covector.js",
10-
"build": "node ./packages/covector/bin/covector.js build",
10+
"build": "yarn workspaces run build",
1111
"test": "jest",
1212
"pretty": "prettier --write \"{src,__{tests,mocks}__}/**/*.{js,ts}\"",
1313
"postinstall": "patch-package"
@@ -23,5 +23,9 @@
2323
"postinstall-postinstall": "^2.1.0",
2424
"prettier": "^2.0.5",
2525
"ts-jest": "^26.1.1"
26+
},
27+
"volta": {
28+
"node": "14.16.0",
29+
"yarn": "1.22.10"
2630
}
2731
}

0 commit comments

Comments
 (0)