Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support curl/wget instead of reqwest to support system proxy/reduce binary size #146

Open
mokeyish opened this issue Jan 17, 2025 · 2 comments

Comments

@mokeyish
Copy link

mokeyish commented Jan 17, 2025

The integration of reqwest is pretty good at the moment, but I found that it doubles the space required for a simple program because it has a lot of dependencies.

Two cargo features, download-system and download-reqwest , could be added to allow choosing between them.

Each platform already has its own download tool, such as curl or wget. If self-update can automatically select and use them, there are two advantages:

  1. Reduce binary size
  2. Suppoert system proxy via ENV: HTTP_PROXY=http://proxy.example.com

If these library are implemented, it may be possible to import it for use.

@mokeyish mokeyish changed the title Support curl/wget instead of reqwest to support system proxy/reduce size Support curl/wget instead of reqwest to support system proxy/reduce binary size Jan 17, 2025
@jaemk
Copy link
Owner

jaemk commented Jan 18, 2025

Hey @mokeyish , I'm open to it. There was a PR (#117 ) opened a while ago that was never fully finished. I'm not sure when I I'll get the chance to either fix up that PR or redo it from scratch, but you're welcome to if you have the time

@mokeyish
Copy link
Author

It looks like a heavy workload. I'll take a look at it and deal with it later when I have time. It probably won't be possible in the near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants