Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: use default workflow working directory #8

Open
orestesgaolin opened this issue Jan 17, 2022 · 1 comment
Open

Feature Request: use default workflow working directory #8

orestesgaolin opened this issue Jan 17, 2022 · 1 comment

Comments

@orestesgaolin
Copy link

Hi there! We're looking into using this workflow in our process, but we found that it's necessary to provide the working directory explicitly. I think it would be much more convenient if the working directory was inferred from the GH Action defaults. e.g.:

name: firebase_authentication_client

on:
  push:
    paths:
      - "packages/authentication_client/firebase_authentication_client/**"
      - ".github/workflows/firebase_authentication_client.yaml"

  pull_request:
    paths:
      - "packages/authentication_client/firebase_authentication_client/**"
      - ".github/workflows/firebase_authentication_client.yaml"

jobs:
  build:
    defaults:
      run:
        working-directory: packages/authentication_client/firebase_authentication_client

    runs-on: ubuntu-latest

    steps:
      - uses: actions/checkout@v2

...

      - name: Analyze
        uses: invertase/github-action-dart-analyzer@v1
        with:
          fatal-infos: true
          fatal-warnings: true
          annotate: true
          annotate-only: false

In the last step named Analyze the working directory should be the same as defaults.working-directory

@aggmoulik
Copy link

Hey @orestesgaolin I can pick this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants