Skip to content

[MAINTAIN] clear up confusion around last/prev/final #1170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2 tasks
sash-a opened this issue Apr 4, 2025 · 0 comments
Open
2 tasks

[MAINTAIN] clear up confusion around last/prev/final #1170

sash-a opened this issue Apr 4, 2025 · 0 comments
Labels
maintenance General improvements/optimisations

Comments

@sash-a
Copy link
Contributor

sash-a commented Apr 4, 2025

Please describe what needs to be maintained?

In some of the code we call the previous step's observation/done last_done and in others we call it prev_done. Additionally, when calculating GAE we usually call it last_done when what we mean is "the last done of the rollout". I think we can clear up the ambiguity by always using prev to mean 1 step back and final to mean the final step of the rollout.

Describe the outcome you'd like

A clear and concise description of what you want to happen.

How do we know when maintenance is complete?

Checklist:

  • the ambiguity around last is cleared up
  • all systems use the same terminology
@sash-a sash-a added the maintenance General improvements/optimisations label Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance General improvements/optimisations
Projects
None yet
Development

No branches or pull requests

1 participant