-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It would be nice to allow a dynamic SendDelay #1184
Comments
Ideally, we'd be able to tune delays around the sampling decision per-rule, since the context we want the rule to evaluate in is usually enough for us to know if we want to wait longer than normal (or ignore the root span closing early). But also, in our environment, asking users to add |
Came across a situation today where allowing SendDelay to be reset whenever a new span arrives would be helpful. (Long trace, variable number of async actions which arrive frequently but over many seconds; it would help to have a debounce model where the trace sends once spans stop arriving.) |
A user in the community just requested this feature because they have high value for long-running jobs but would like to lower it for certain traffic |
Yeah the debounce option would be great for my company too. If I raised a PR for |
Is your feature request related to a problem? Please describe.
For async systems, sometimes different parts of the system need different amounts of time to expect the rest of the trace to arrive. A global SendDelay setting causes all traces to have to wait for the worst case.
Customer:
Describe the solution you'd like
If the root span has a numeric field called
refinery.trace_send_delay
, then instead of using the configured SendDelay, refinery will wait for the number of seconds specified in that field before deciding on that trace.Describe alternatives you've considered
DecisionTimeout
or something) -- if configured, any new span that arrives for a trace resets that trace's clock, so that as long as late spans aren't TOO late, the trace will delay decisions; only when they slow down enough does the decision get made.Additional context
Slack thread in pollinators
The text was updated successfully, but these errors were encountered: