Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The ability to disable logging for Webui #6867

Closed
1 task done
XeTute opened this issue Feb 8, 2025 · 2 comments
Closed
1 task done

The ability to disable logging for Webui #6867

XeTute opened this issue Feb 8, 2025 · 2 comments
Labels
enhancement New feature or request pending This problem is yet to be addressed

Comments

@XeTute
Copy link

XeTute commented Feb 8, 2025

Reminder

  • I have read the above rules and searched the existing issues.

Description

Hello there.
I request a feature in the Webui to turn of logging for training. If the log gets too large (too long string / too many characters), the Webui page stops responding and some browsers even crash due to not being able to render that many characters. You can easily reproduce this by training a small model for many many epochs on a large dataset, and at some point, the log on the Webui will get too long and crash the page.
A fix for this would be, as previously mentioned, to give users the ability to turn off the log from trying to render on the page, or to add a character limit and 'slide' new characters in while deleting old one which go out of the window.
Thanks.

Pull Request

No response

@XeTute XeTute added enhancement New feature or request pending This problem is yet to be addressed labels Feb 8, 2025
@hiyouga
Copy link
Owner

hiyouga commented Feb 8, 2025

Do you mean reducing the length of running_log?

running_log = f.read()

@XeTute
Copy link
Author

XeTute commented Feb 8, 2025

Do you mean reducing the length of running_log?

LLaMA-Factory/src/llamafactory/webui/control.py

Line 107 in 1356f9d

running_log = f.read()

Yes, exactly! Thanks a lot, my normal language is C++ so I wasn't quite able to grasp the Python code. Thanks again for helping me out!

@XeTute XeTute closed this as completed Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pending This problem is yet to be addressed
Projects
None yet
Development

No branches or pull requests

2 participants