Skip to content

Commit 9ec3ff6

Browse files
sentozdehaansa
andauthored
fix(helm): extra volume mounts (#3736)
* fix: list extra volumeMounts * chore; helm test update * docs: update helm changelog * Update operations/helm/charts/alloy/CHANGELOG.md --------- Co-authored-by: Sam DeHaan <[email protected]>
1 parent a153152 commit 9ec3ff6

File tree

5 files changed

+9
-8
lines changed

5 files changed

+9
-8
lines changed

operations/helm/charts/alloy/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,10 @@ internal API changes are not present.
1010
Unreleased
1111
----------
1212

13+
### Bug fixes
14+
15+
- Fix `alloy.mounts.extra` incorrect list after templating. (@sentoz)
16+
1317
1.1.0 (2025-06-02)
1418
----------
1519

operations/helm/charts/alloy/templates/containers/_agent.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@
8686
mountPath: /var/lib/docker/containers
8787
readOnly: true
8888
{{- end }}
89-
{{- range $values.mounts.extra }}
90-
- {{- toYaml . | nindent 6 }}
89+
{{- with $values.mounts.extra }}
90+
{{- toYaml . | nindent 4 }}
9191
{{- end }}
9292
{{- end }}

operations/helm/tests/controller-volumes-extra/alloy/templates/controllers/daemonset.yaml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,7 @@ spec:
5757
volumeMounts:
5858
- name: config
5959
mountPath: /etc/alloy
60-
-
61-
mountPath: /cache
60+
- mountPath: /cache
6261
name: cache-volume
6362
- name: config-reloader
6463
image: quay.io/prometheus-operator/prometheus-config-reloader:v0.81.0

operations/helm/tests/initcontainers/alloy/templates/controllers/daemonset.yaml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,8 +75,7 @@ spec:
7575
volumeMounts:
7676
- name: config
7777
mountPath: /etc/alloy
78-
-
79-
mountPath: /etc/geoip
78+
- mountPath: /etc/geoip
8079
name: geoip
8180
- name: config-reloader
8281
image: quay.io/prometheus-operator/prometheus-config-reloader:v0.81.0

operations/helm/tests/sidecars/alloy/templates/controllers/daemonset.yaml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,7 @@ spec:
5757
volumeMounts:
5858
- name: config
5959
mountPath: /etc/alloy
60-
-
61-
mountPath: /etc/geoip
60+
- mountPath: /etc/geoip
6261
name: geoip
6362
- name: config-reloader
6463
image: quay.io/prometheus-operator/prometheus-config-reloader:v0.81.0

0 commit comments

Comments
 (0)