Skip to content

The Pulls Request page has incorrect sorting when there are query conditions. #34523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seepine opened this issue May 23, 2025 · 1 comment · May be fixed by #34559
Open

The Pulls Request page has incorrect sorting when there are query conditions. #34523

seepine opened this issue May 23, 2025 · 1 comment · May be fixed by #34559
Labels
Milestone

Comments

@seepine
Copy link

seepine commented May 23, 2025

Description

visit https://git.example.com/pulls

  1. The sort of pr is
    • A1
    • A2
    • A3
  2. Then A3 has new push, the sort is
    • A3
    • A1
    • A2
  3. Then query the keyword A, the sort is
    • A1
    • A2
    • A3

Gitea Version

1.23.7

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

Image

Image

Git Version

No response

Operating System

No response

How are you running Gitea?

docker

Database

MySQL/MariaDB

@badhezi
Copy link
Contributor

badhezi commented May 28, 2025

I believe the issue here is that sort query parameter is discarded when a keyword filter is introduced.
created #34559
I also believe the correct behavior is to retain the sort type when searching, i.e you want to see all recently updated PRs that include "X" keyword.

@lunny lunny added this to the 1.24.0 milestone May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants