Action don't show the Skip Icon if skipped

[wienans]

Description

In a Pull Request the Skipped Icons show the checkmark, instead of a skipped icon.

The text is correct but having the check mark is confusing if one does not look correctly

Gitea Version

1.23.1 built with GNU Make 4.3, go1.23.4 : bindata, sqlite, sqlite_unlock_notify

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

is:

should be:

Git Version

No response

Operating System

No response

How are you running Gitea?

Windows Server

Database

MSSQL

[badhezi]

Are you sure it has not errored?
this is what i get when a job within a workflow has been skipped due to if conditional in the workflow yaml.
(still i would change the green check to the skip icon)

[wienans]

Sorry maybe I wasn’t specific enough. The one which says failed is obviously correct and failed but the skipped once show the green checkmark icon instead of the skip icon and that is what I was talking about.

[badhezi]

ahh yes i see, sorry i was a bit confused there.
I'll check how to address this

[badhezi]

Created #34507 to address this

[lunny]

Skipped merged as success in #23786. Maybe we can start from there.

[badhezi]

Skipped merged as success in #23786. Maybe we can start from there.

I think my PR resolves this no?

[lunny]

Skipped merged as success in #23786. Maybe we can start from there.

I think my PR resolves this no?

I haven't do a full review but it seems there are more places need to be checked.

[wienans]

Thanks to you all and especially @badhezi to directly jump on it. 🚀