Set mouseDown flag before reporting mouse down; otherwise we return and mouseUp doesn't think there was a mouseDown.

gnachman · gnachman · commit 6f43144f9ff9 · 2014-06-07T17:35:28.000-07:00
diff --git a/PTYTextView.m b/PTYTextView.m
@@ -2919,6 +2919,8 @@ - (BOOL)mouseDownImpl:(NSEvent*)event
         }
     }
 
+    mouseDown = YES;
+
     if ([self reportMouseEvent:event]) {
         return NO;
     }
@@ -2932,7 +2934,6 @@ - (BOOL)mouseDownImpl:(NSEvent*)event
     [mouseDownEvent autorelease];
     mouseDownEvent = [event retain];
     mouseDragged = NO;
-    mouseDown = YES;
     mouseDownOnSelection = NO;
     mouseDownOnImage = NO;
 

Original file line number	Diff line number	Diff line change
`@@ -2919,6 +2919,8 @@ - (BOOL)mouseDownImpl:(NSEvent*)event`
`2919`	`2919`	`}`
`2920`	`2920`	`}`
`2921`	`2921`
	`2922`	`+ mouseDown = YES;`
	`2923`	`+`
`2922`	`2924`	`if ([self reportMouseEvent:event]) {`
`2923`	`2925`	`return NO;`
`2924`	`2926`	`}`
`@@ -2932,7 +2934,6 @@ - (BOOL)mouseDownImpl:(NSEvent*)event`
`2932`	`2934`	`[mouseDownEvent autorelease];`
`2933`	`2935`	`mouseDownEvent = [event retain];`
`2934`	`2936`	`mouseDragged = NO;`
`2935`		`- mouseDown = YES;`
`2936`	`2937`	`mouseDownOnSelection = NO;`
`2937`	`2938`	`mouseDownOnImage = NO;`
`2938`	`2939`