Skip to content

Commit 152587d

Browse files
committed
Rename Note to Annotation and move Edit>Show/Hide note to View>Toggle Annotation.
1 parent 385981c commit 152587d

File tree

4 files changed

+22
-20
lines changed

4 files changed

+22
-20
lines changed

English.lproj/MainMenu.xib

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
2-
<document type="com.apple.InterfaceBuilder3.Cocoa.XIB" version="3.0" toolsVersion="4514" systemVersion="13A2093" targetRuntime="MacOSX.Cocoa" propertyAccessControl="none">
2+
<document type="com.apple.InterfaceBuilder3.Cocoa.XIB" version="3.0" toolsVersion="5053" systemVersion="13C64" targetRuntime="MacOSX.Cocoa" propertyAccessControl="none">
33
<dependencies>
44
<deployment defaultVersion="1070" identifier="macosx"/>
5-
<plugIn identifier="com.apple.InterfaceBuilder.CocoaPlugin" version="4514"/>
5+
<plugIn identifier="com.apple.InterfaceBuilder.CocoaPlugin" version="5053"/>
66
</dependencies>
77
<objects>
88
<customObject id="-2" userLabel="File's Owner" customClass="NSApplication">
@@ -501,35 +501,30 @@ DQ
501501
<action selector="jumpToSavedScrollPosition:" target="-1" id="1248"/>
502502
</connections>
503503
</menuItem>
504-
<menuItem title="Previous mark/note" keyEquivalent="" id="sZa-7I-YDa">
504+
<menuItem title="Previous Mark/Annotation" keyEquivalent="" id="sZa-7I-YDa">
505505
<modifierMask key="keyEquivalentModifierMask" shift="YES" command="YES"/>
506506
<connections>
507507
<action selector="previousMarkOrNote:" target="-1" id="Qrg-Y8-KM2"/>
508508
</connections>
509509
</menuItem>
510-
<menuItem title="Next mark/note" keyEquivalent="" id="mcu-LX-9Aj">
510+
<menuItem title="Next Mark/Annotation" keyEquivalent="" id="mcu-LX-9Aj">
511511
<modifierMask key="keyEquivalentModifierMask" shift="YES" command="YES"/>
512512
<connections>
513513
<action selector="nextMarkOrNote:" target="-1" id="HSR-a4-u0F"/>
514514
</connections>
515515
</menuItem>
516-
<menuItem title="Alert on next mark" keyEquivalent="a" id="Qj6-xH-l9X">
516+
<menuItem title="Alert on Next Mark" keyEquivalent="a" id="Qj6-xH-l9X">
517517
<modifierMask key="keyEquivalentModifierMask" option="YES" command="YES"/>
518518
<connections>
519519
<action selector="toggleAlertOnNextMark:" target="-1" id="hTO-Iy-yuC"/>
520520
</connections>
521521
</menuItem>
522-
<menuItem title="Add note at cursor" keyEquivalent="m" id="Fna-Ng-9y6">
522+
<menuItem title="Add Annotation at Cursor" keyEquivalent="m" id="Fna-Ng-9y6">
523523
<modifierMask key="keyEquivalentModifierMask" option="YES" command="YES"/>
524524
<connections>
525525
<action selector="addNoteAtCursor:" target="-1" id="B5P-c8-bDe"/>
526526
</connections>
527527
</menuItem>
528-
<menuItem title="Show/Hide notes" keyEquivalent="\" id="pAu-j3-wEC">
529-
<connections>
530-
<action selector="showHideNotes:" target="-1" id="bWx-ZS-6aE"/>
531-
</connections>
532-
</menuItem>
533528
<menuItem isSeparatorItem="YES" id="1238">
534529
<modifierMask key="keyEquivalentModifierMask" command="YES"/>
535530
<menu key="submenu" id="1239">
@@ -613,6 +608,11 @@ DQ
613608
<action selector="toggleShowTimestamps:" target="-1" id="oGg-h2-Ex7"/>
614609
</connections>
615610
</menuItem>
611+
<menuItem title="Toggle Annotations" keyEquivalent="\" id="pAu-j3-wEC">
612+
<connections>
613+
<action selector="showHideNotes:" target="-1" id="bWx-ZS-6aE"/>
614+
</connections>
615+
</menuItem>
616616
<menuItem title="Automatic Command History" keyEquivalent="Y" id="9DF-nf-qif">
617617
<modifierMask key="keyEquivalentModifierMask" option="YES" command="YES"/>
618618
<connections>
@@ -928,7 +928,7 @@ DQ
928928
</connections>
929929
</customObject>
930930
<customObject id="266" userLabel="Font Manager" customClass="NSFontManager"/>
931-
<window title="About iTerm" allowsToolTipsWhenApplicationIsInactive="NO" autorecalculatesKeyViewLoop="NO" releasedWhenClosed="NO" wantsToBeColor="NO" visibleAtLaunch="NO" animationBehavior="default" id="498" userLabel="About" customClass="iTermAboutWindow">
931+
<window title="About iTerm" allowsToolTipsWhenApplicationIsInactive="NO" autorecalculatesKeyViewLoop="NO" releasedWhenClosed="NO" visibleAtLaunch="NO" animationBehavior="default" id="498" userLabel="About" customClass="iTermAboutWindow">
932932
<windowStyleMask key="styleMask" titled="YES" closable="YES"/>
933933
<windowPositionMask key="initialPositionMask" leftStrut="YES" rightStrut="YES" topStrut="YES" bottomStrut="YES"/>
934934
<rect key="contentRect" x="386" y="524" width="354" height="164"/>
@@ -1040,4 +1040,4 @@ DQ
10401040
<resources>
10411041
<image name="NSApplicationIcon" width="128" height="128"/>
10421042
</resources>
1043-
</document>
1043+
</document>

VT100Terminal.m

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1626,9 +1626,11 @@ - (void)executeXtermSetKvp:(VT100Token *)token {
16261626
[delegate_ terminalCurrentDirectoryDidChangeTo:value];
16271627
} else if ([key isEqualToString:@"SetProfile"]) {
16281628
[delegate_ terminalProfileShouldChangeTo:(NSString *)value];
1629-
} else if ([key isEqualToString:@"AddNote"]) {
1629+
} else if ([key isEqualToString:@"AddNote"] || // Deprecated
1630+
[key isEqualToString:@"AddAnnotation"]) {
16301631
[delegate_ terminalAddNote:(NSString *)value show:YES];
1631-
} else if ([key isEqualToString:@"AddHiddenNote"]) {
1632+
} else if ([key isEqualToString:@"AddHiddenNote"] || // Deprecated
1633+
[key isEqualToString:@"AddHiddenAnnotation"]) {
16321634
[delegate_ terminalAddNote:(NSString *)value show:NO];
16331635
} else if ([key isEqualToString:@"HighlightCursorLine"]) {
16341636
[delegate_ terminalSetHighlightCursorLine:value.length ? [value boolValue] : YES];

tests/annotation

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
The word NOTE should have an annotation
2+
The word ]1337;AddAnnotation=4|This is the word notenote should have an annotation.
3+
There should be an annotation from here ->]1337;AddAnnotation=A note til EOLtil the end of the line
4+
The word ]1337;AddHiddenAnnotation=4|Hidden annotationnote should have a hidden annotation
5+
]1337;AddAnnotation=9|0|4|Absolute position

tests/note

Lines changed: 0 additions & 5 deletions
This file was deleted.

0 commit comments

Comments
 (0)